Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329486: Issue 3208 - Adjust unit tests for the content policy changes (Closed)

Created:
Oct. 29, 2015, 1:59 p.m. by Wladimir Palant
Modified:
Nov. 12, 2015, 6:44 p.m.
Visibility:
Public.

Description

Note that test_requestList.html is currently dead code, it was never converted for qUnit.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chrome/content/tests/policy.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/test_requestList.html View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Oct. 29, 2015, 1:59 p.m. (2015-10-29 13:59:39 UTC) #1
tschuster
On 2015/10/29 13:59:39, Wladimir Palant wrote: LGTM I am actually surprised that we only need ...
Nov. 12, 2015, 1:26 p.m. (2015-11-12 13:26:07 UTC) #2
Wladimir Palant
Nov. 12, 2015, 6:44 p.m. (2015-11-12 18:44:09 UTC) #3
On 2015/11/12 13:26:07, tschuster wrote:
> I am actually surprised that we only need such small changes.

That's only the first part. Once the content policy module is split up into two
parts more extensive changes become necessary, that's issue 3226.

Powered by Google App Engine
This is Rietveld