Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329547: Issue 3208 - Move isBlockableScheme call from shouldLoad() into processNode() (Closed)

Created:
Oct. 30, 2015, 7:43 p.m. by Wladimir Palant
Modified:
Nov. 11, 2015, 2:08 p.m.
Visibility:
Public.

Description

Issue 3208 - Move isBlockableScheme call from shouldLoad() into processNode()

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M lib/contentPolicy.js View 1 3 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 6
Wladimir Palant
Oct. 30, 2015, 7:43 p.m. (2015-10-30 19:43:21 UTC) #1
tschuster
https://codereview.adblockplus.org/29329547/diff/29329548/lib/contentPolicy.js File lib/contentPolicy.js (right): https://codereview.adblockplus.org/29329547/diff/29329548/lib/contentPolicy.js#newcode271 lib/contentPolicy.js:271: scheme = match ? match[0] : null; match[1]
Oct. 31, 2015, 12:25 p.m. (2015-10-31 12:25:11 UTC) #2
Wladimir Palant
Fixed typo
Nov. 1, 2015, 12:23 p.m. (2015-11-01 12:23:04 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29329547/diff/29329548/lib/contentPolicy.js File lib/contentPolicy.js (right): https://codereview.adblockplus.org/29329547/diff/29329548/lib/contentPolicy.js#newcode271 lib/contentPolicy.js:271: scheme = match ? match[0] : null; On 2015/10/31 ...
Nov. 1, 2015, 12:23 p.m. (2015-11-01 12:23:37 UTC) #4
tschuster
LGTM
Nov. 2, 2015, 8:56 p.m. (2015-11-02 20:56:33 UTC) #5
Thomas Greiner
Nov. 3, 2015, 6:26 p.m. (2015-11-03 18:26:39 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld