Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329554: Issue 3208 - Send Private Browsing flag separately from the frame structure (Closed)

Created:
Oct. 30, 2015, 7:57 p.m. by Wladimir Palant
Modified:
Nov. 4, 2015, 9:41 a.m.
Visibility:
Public.

Description

Adding that flag to the frame structure was really a hack.

Patch Set 1 #

Patch Set 2 : Fixed PrivateBrowsingUtils call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M lib/child/elemHide.js View 2 chunks +4 lines, -2 lines 0 comments Download
M lib/child/utils.js View 1 1 chunk +10 lines, -4 lines 0 comments Download
M lib/elemHide.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Oct. 30, 2015, 7:57 p.m. (2015-10-30 19:57:14 UTC) #1
Thomas Greiner
Nov. 3, 2015, 6:33 p.m. (2015-11-03 18:33:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld