Noissue - Avoid "detached head" when using Git branches

Noissue - Avoid "detached head" when using Git branches

[kzar, 2015-10-30 20:23:12]

Patch Set 1

Small change so that we check out the specified revision as given when using
Git, instead of the resolved revision.

This helps avoid a small annoyance whereby if I specify a branch name for the
revision of a dependency the script would check out the commit the branch points
at, instead of the branch itself. In Git when you do that you end up with a
"detached head" state, and it meant that I had to manually go into the
dependency and check out the branch name before I could commit further changes
to it.

I found this made it more painful to work on issues that required a feature
branch for multiple interacting repositories, for example when implementing
generic hide / block required interacting changes to adblockplus
adblockpluschrome and adblockplustests.

[Wladimir Palant, 2015-11-10 10:53:17]

https://codereview.adblockplus.org/29329559/diff/29329560/ensure_dependencies.py
File ensure_dependencies.py (right):

https://codereview.adblockplus.org/29329559/diff/29329560/ensure_dependencies...
ensure_dependencies.py:69: def update(self, repo, rev, _):
Please replace _ by revname so that the parameters are consistent.

https://codereview.adblockplus.org/29329559/diff/29329560/ensure_dependencies...
ensure_dependencies.py:125: def update(self, repo, _, rev):
Please replace _ by rev and rev by revname so that the parameters are
consistent. The command below should operate on revname, this will make things
more obvious.

[kzar, 2015-11-10 12:21:29]

Patch Set 2 : Name parameters consistently

https://codereview.adblockplus.org/29329559/diff/29329560/ensure_dependencies.py
File ensure_dependencies.py (right):

https://codereview.adblockplus.org/29329559/diff/29329560/ensure_dependencies...
ensure_dependencies.py:69: def update(self, repo, rev, _):
On 2015/11/10 10:53:17, Wladimir Palant wrote:
> Please replace _ by revname so that the parameters are consistent.

Done.

https://codereview.adblockplus.org/29329559/diff/29329560/ensure_dependencies...
ensure_dependencies.py:125: def update(self, repo, _, rev):
On 2015/11/10 10:53:17, Wladimir Palant wrote:
> Please replace _ by rev and rev by revname so that the parameters are
> consistent. The command below should operate on revname, this will make things
> more obvious.

Done.

[Wladimir Palant, 2015-11-10 12:28:04]

LGTM