Issue 3208 - Generalize getFrames() function to return the effective frame structure

These changes don`t really matter for element hiding but they are important in order to use this function for the content policy. getWindowLocation() was copied from there (plus anchor removal), inheritance code comes from Utils.getOriginWindow()

[Thomas Greiner, 2015-11-10 18:41:23]

https://codereview.adblockplus.org/29329562/diff/29329563/lib/child/utils.js
File lib/child/utils.js (right):

https://codereview.adblockplus.org/29329562/diff/29329563/lib/child/utils.js#...
lib/child/utils.js:98: // URLs like about:blank inherit their security context
from upper-level
So with "URLs like about:blank" you mean "about:blank" and
"moz-safe-about:blank" or are those only the ones you're aware of?

https://codereview.adblockplus.org/29329562/diff/29329563/lib/child/utils.js#...
lib/child/utils.js:106: frames[i].location = frames[i + 1].location;
Detail: You already have a reference to `frame[i]` in the variable `frame` so
you can get rid of `s[i]` here.

[Wladimir Palant, 2015-11-11 08:01:28]

https://codereview.adblockplus.org/29329562/diff/29329563/lib/child/utils.js
File lib/child/utils.js (right):

https://codereview.adblockplus.org/29329562/diff/29329563/lib/child/utils.js#...
lib/child/utils.js:98: // URLs like about:blank inherit their security context
from upper-level
On 2015/11/10 18:41:23, Thomas Greiner wrote:
> So with "URLs like about:blank" you mean "about:blank" and
> "moz-safe-about:blank" or are those only the ones you're aware of?

No, normally that's protocol-dependent - data:, javascript: and wyciwig:
protocols implement URI_INHERITS_SECURITY_CONTEXT flag which is also checked.

https://codereview.adblockplus.org/29329562/diff/29329563/lib/child/utils.js#...
lib/child/utils.js:106: frames[i].location = frames[i + 1].location;
On 2015/11/10 18:41:23, Thomas Greiner wrote:
> Detail: You already have a reference to `frame[i]` in the variable `frame` so
> you can get rid of `s[i]` here.

Done.

[Thomas Greiner, 2015-11-11 12:00:46]

LGTM