Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329568: Issue 3208 - Moved checks related to context elements from Policy.shouldProcess() to PolicyImplemen… (Closed)

Created:
Oct. 30, 2015, 11:40 p.m. by Wladimir Palant
Modified:
Nov. 11, 2015, 2:13 p.m.
Visibility:
Public.

Description

Issue 3208 - Moved checks related to context elements from Policy.shouldProcess() to PolicyImplemen…

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M lib/contentPolicy.js View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Oct. 30, 2015, 11:40 p.m. (2015-10-30 23:40:35 UTC) #1
Thomas Greiner
LGTM Note that the review title mentions `Policy.shouldProcess()` which, however, doesn't exist.
Nov. 3, 2015, 6:53 p.m. (2015-11-03 18:53:06 UTC) #2
Wladimir Palant
Nov. 4, 2015, 9:38 a.m. (2015-11-04 09:38:44 UTC) #3
On 2015/11/03 18:53:06, Thomas Greiner wrote:
> Note that the review title mentions `Policy.shouldProcess()` which, however,
> doesn't exist.

Thank you, I fixed the commit message (should be Policy.processNode() of
course).

Powered by Google App Engine
This is Rietveld