Issue 29329597: Issue 3253 - Adblock Warning List opt in message should not be triggered by frames (Firefox)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29329597: Issue 3253 - Adblock Warning List opt in message should not be triggered by frames (Firefox) (Closed)

Created:
Nov. 2, 2015, 11:41 a.m. by Wladimir Palant

Modified:
Nov. 2, 2015, 1:34 p.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

Issue 3253 - Adblock Warning List opt in message should not be triggered by frames (Firefox)

Patch Set 1 #

Total comments: 2

Created: Nov. 2, 2015, 11:41 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -16 lines)			Patch
	M	lib/notification.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	lib/ui.js	View		2 chunks	+2 lines, -15 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Thomas Greiner

LGTM https://codereview.adblockplus.org/29329597/diff/29329598/lib/ui.js File lib/ui.js (right): https://codereview.adblockplus.org/29329597/diff/29329598/lib/ui.js#newcode597 lib/ui.js:597: Notification.showNext(this.getCurrentLocation(window).spec); Detail: Not directly related to this ticket ...

Nov. 2, 2015, 12:42 p.m. (2015-11-02 12:42:52 UTC) #2

Wladimir Palant

Nov. 2, 2015, 1:34 p.m. (2015-11-02 13:34:24 UTC) #3

https://codereview.adblockplus.org/29329597/diff/29329598/lib/ui.js
File lib/ui.js (right):

https://codereview.adblockplus.org/29329597/diff/29329598/lib/ui.js#newcode597
lib/ui.js:597: Notification.showNext(this.getCurrentLocation(window).spec);
On 2015/11/02 12:42:52, Thomas Greiner wrote:
> Detail: Not directly related to this ticket but according to the documentation
> in lib/appSupport.js this function (getCurrentLocation) returns either a
nsIURI
> or a string. However, I don't see how it could ever return a string so might
> make sense adapating the documentation.

Actually, getCurrentLocation in appSupport.js *can* return a string - on
Thunderbird. However, UI.getCurrentLocation that we are calling here will always
return an nsIURI because of the Utils.unwrapURL call.

Expand All Messages | Collapse All Messages