Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(315)

Issue 29329663: Issue 3222 - Mostly unbreak blockable items (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by Wladimir Palant
Modified:
4 years ago
Visibility:
Public.

Description

Issue 3222 - Mostly unbreak blockable items

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -45 lines) Patch
M chrome/content/ui/sidebar.js View 17 chunks +73 lines, -45 lines 3 comments Download

Messages

Total messages: 5
Wladimir Palant
4 years, 1 month ago (2015-11-02 19:59:44 UTC) #1
Wladimir Palant
Everything seems to be working with the exception noted below. The change is mostly about ...
4 years, 1 month ago (2015-11-02 20:01:59 UTC) #2
tschuster
On 2015/11/02 20:01:59, Wladimir Palant wrote: > Everything seems to be working with the exception ...
4 years ago (2015-11-12 13:35:30 UTC) #3
tschuster
I guess I am just going to LGTM this. https://codereview.adblockplus.org/29329663/diff/29329664/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (right): https://codereview.adblockplus.org/29329663/diff/29329664/chrome/content/ui/sidebar.js#newcode119 chrome/content/ui/sidebar.js:119: ...
4 years ago (2015-11-12 15:32:05 UTC) #4
Wladimir Palant
4 years ago (2015-11-12 15:46:56 UTC) #5
https://codereview.adblockplus.org/29329663/diff/29329664/chrome/content/ui/s...
File chrome/content/ui/sidebar.js (right):

https://codereview.adblockplus.org/29329663/diff/29329664/chrome/content/ui/s...
chrome/content/ui/sidebar.js:119: if ("filter" in item && item.filter)
On 2015/11/12 15:32:05, tschuster wrote:
> "filter" in item is not strictly necessary.

Yes, I know but I didn't feel like changing that. The code here actually avoids
touching undefined values consistently. Background of this is that Firefox used
to warn for those if javascript.options.strict was enabled.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5