Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329663: Issue 3222 - Mostly unbreak blockable items (Closed)

Created:
Nov. 2, 2015, 7:59 p.m. by Wladimir Palant
Modified:
Nov. 12, 2015, 3:47 p.m.
Visibility:
Public.

Description

Issue 3222 - Mostly unbreak blockable items

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -45 lines) Patch
M chrome/content/ui/sidebar.js View 17 chunks +73 lines, -45 lines 3 comments Download

Messages

Total messages: 5
Wladimir Palant
Nov. 2, 2015, 7:59 p.m. (2015-11-02 19:59:44 UTC) #1
Wladimir Palant
Everything seems to be working with the exception noted below. The change is mostly about ...
Nov. 2, 2015, 8:01 p.m. (2015-11-02 20:01:59 UTC) #2
tschuster
On 2015/11/02 20:01:59, Wladimir Palant wrote: > Everything seems to be working with the exception ...
Nov. 12, 2015, 1:35 p.m. (2015-11-12 13:35:30 UTC) #3
tschuster
I guess I am just going to LGTM this. https://codereview.adblockplus.org/29329663/diff/29329664/chrome/content/ui/sidebar.js File chrome/content/ui/sidebar.js (right): https://codereview.adblockplus.org/29329663/diff/29329664/chrome/content/ui/sidebar.js#newcode119 chrome/content/ui/sidebar.js:119: ...
Nov. 12, 2015, 3:32 p.m. (2015-11-12 15:32:05 UTC) #4
Wladimir Palant
Nov. 12, 2015, 3:46 p.m. (2015-11-12 15:46:56 UTC) #5
https://codereview.adblockplus.org/29329663/diff/29329664/chrome/content/ui/s...
File chrome/content/ui/sidebar.js (right):

https://codereview.adblockplus.org/29329663/diff/29329664/chrome/content/ui/s...
chrome/content/ui/sidebar.js:119: if ("filter" in item && item.filter)
On 2015/11/12 15:32:05, tschuster wrote:
> "filter" in item is not strictly necessary.

Yes, I know but I didn't feel like changing that. The code here actually avoids
touching undefined values consistently. Background of this is that Firefox used
to warn for those if javascript.options.strict was enabled.

Powered by Google App Engine
This is Rietveld