Issue 29329742: Issue 3251 - Simplify messaging from child scripts to parent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29329742: Issue 3251 - Simplify messaging from child scripts to parent (Closed)

Created:
Nov. 4, 2015, 2:58 p.m. by Wladimir Palant

Modified:
Nov. 16, 2015, 12:59 p.m.

Reviewers:
Thomas Greiner, tschuster

Visibility:
Public.

Description

Issue 3251 - Simplify messaging from child scripts to parent

Patch Set 2 : Rebased, no return value stringification #

Patch Set 3 : Adjusted a caller that was forgotten #

Patch Set 5 : Rebased #

Total comments: 2

Created: Nov. 12, 2015, 12:29 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -47 lines)			Patch
M	lib/child/bootstrap.js	View	1	2 chunks	+38 lines, -1 line	2 comments	Download
M	lib/child/contentPolicy.js	View	1 2 3	2 chunks	+3 lines, -7 lines	0 comments	Download
M	lib/child/elemHide.js	View		2 chunks	+3 lines, -11 lines	0 comments	Download
M	lib/contentPolicy.js	View	1 2 3 4	1 chunk	+2 lines, -10 lines	0 comments	Download
M	lib/elemHide.js	View		1 chunk	+2 lines, -8 lines	0 comments	Download
M	lib/requestNotifier.js	View		1 chunk	+7 lines, -10 lines	0 comments	Download
M	lib/utils.js	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Wladimir Palant

https://codereview.adblockplus.org/29329742/diff/29329743/lib/child/bootstrap.js File lib/child/bootstrap.js (right): https://codereview.adblockplus.org/29329742/diff/29329743/lib/child/bootstrap.js#newcode64 lib/child/bootstrap.js:64: function sendAsyncMessageWithResponse(messageName, data, callback) Note that normally the third ...

Nov. 4, 2015, 3:04 p.m. (2015-11-04 15:04:09 UTC) #2

tschuster

LGTM https://codereview.adblockplus.org/29329742/diff/29330076/lib/child/bootstrap.js File lib/child/bootstrap.js (right): https://codereview.adblockplus.org/29329742/diff/29330076/lib/child/bootstrap.js#newcode96 lib/child/bootstrap.js:96: sendAsyncMessage: sendAsyncMessageWithResponse, I don't think it's great that ...

Nov. 14, 2015, 9:26 p.m. (2015-11-14 21:26:08 UTC) #3

Wladimir Palant

Nov. 16, 2015, 12:54 p.m. (2015-11-16 12:54:24 UTC) #4

https://codereview.adblockplus.org/29329742/diff/29330076/lib/child/bootstrap.js
File lib/child/bootstrap.js (right):

https://codereview.adblockplus.org/29329742/diff/29330076/lib/child/bootstrap...
lib/child/bootstrap.js:96: sendAsyncMessage: sendAsyncMessageWithResponse,
On 2015/11/14 21:26:07, tschuster wrote:
> I don't think it's great that we use the same name for those as the standard
> functions, but I don't have good name suggestion now either.

I don't think these will stay like that. My idea is to implement a proper
messaging module and then merge the messaging functionality currently in
ext/common into it as well. But - enough changes for now, that refactoring will
happen along with the CSS Property Filters implementation.

Expand All Messages | Collapse All Messages