Issue 3251 - Delegate processing of element hiding hits to shouldAllowAsync() so that hits show up

lib/child/contentPolicy.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 86 matching lines @@
       schedulePostProcess(node);
   }
   return allow;
 }
 
 /**
  * Checks whether a request should be allowed, hides it if necessary
  * @param {nsIDOMWindow} window
  * @param {nsIDOMElement} node
  * @param {String} contentType
- * @param {String} location
+ * @param {String} location location of the request, filter key if contentType is ELEMHIDE
  * @return {Boolean} false if the request should be blocked
  */
-function shouldAllow(window, node, contentType, location)
+let shouldAllow = exports.shouldAllow = function(window, node, contentType, location)
 {
   return processPolicyResponse(window, node, sendSyncMessage("AdblockPlus:ShouldAllow", {
     contentType,
     location,
     frames: getFrames(window),
     isPrivate: isPrivate(window)
   }));
-}
+};
 
 /**
  * Asynchronously checks whether a request should be allowed.
  * @param {nsIDOMWindow} window
  * @param {nsIDOMElement} node
  * @param {String} contentType
- * @param {String} location
+ * @param {String} location location of the request, filter key if contentType is ELEMHIDE
  * @param {Function} callback  callback to be called with a boolean value, if
  *                             false the request should be blocked
  */
-function shouldAllowAsync(window, node, contentType, location, callback)
+let shouldAllowAsync = exports.shouldAllowAsync = function(window, node, contentType, location, callback)
 {
   sendAsyncMessage("AdblockPlus:ShouldAllow", {
     contentType,
     location,
     frames: getFrames(window),
     isPrivate: isPrivate(window)
   }, response => callback(processPolicyResponse(window, node, response)));
-}
+};
 
 /**
  * Actual nsIContentPolicy and nsIChannelEventSink implementation
  * @class
  */
 var PolicyImplementation =
 {
   classDescription: "Adblock Plus content policy",
   classID: Components.ID("cfeaabe6-1dd1-11b2-a0c6-cb5c268894c9"),
   contractID: "@adblockplus.org/abp/policy;1",
@@ skipping 231 matching lines @@
         let property = (hasCols ? "cols" : "rows");
         let weights = parentNode[property].split(",");
         weights[index] = "0";
         parentNode[property] = weights.join(",");
       }
     }
     else
       node.classList.add(collapsedClass);
   }
 }