Issue 29329754: Issue 3251 - Delegate processing of element hiding hits to shouldAllowAsync() so that hits show up

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29329754: Issue 3251 - Delegate processing of element hiding hits to shouldAllowAsync() so that hits show up (Closed)

Created:
Nov. 4, 2015, 3 p.m. by Wladimir Palant

Modified:
Nov. 19, 2015, 6:06 p.m.

Reviewers:
Thomas Greiner, tschuster

Visibility:
Public.

Description

Issue 3251 - Delegate processing of element hiding hits to shouldAllowAsync() so that hits show up in blockable items again

Patch Set 2 : Reversed logic and improved JSDoc comments #

Patch Set 4 : Rebased #

Total comments: 1

Created: Nov. 12, 2015, 3:04 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -44 lines)			Patch
M	lib/child/contentPolicy.js	View	1 2 3	1 chunk	+6 lines, -6 lines	0 comments	Download
M	lib/child/elemHide.js	View	1 2 3	2 chunks	+4 lines, -8 lines	1 comment	Download
M	lib/contentPolicy.js	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/elemHide.js	View		2 chunks	+0 lines, -28 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

tschuster

LGTM https://codereview.adblockplus.org/29329754/diff/29329755/lib/contentPolicy.js File lib/contentPolicy.js (right): https://codereview.adblockplus.org/29329754/diff/29329755/lib/contentPolicy.js#newcode181 lib/contentPolicy.js:181: match = ElemHide.getFilterByKey(location); So this is better, but ...

Nov. 5, 2015, 3:39 p.m. (2015-11-05 15:39:37 UTC) #2

Wladimir Palant

I realized that this patch had a major flaw - the return value of shouldHide ...

Nov. 6, 2015, 11:29 a.m. (2015-11-06 11:29:01 UTC) #3

Wladimir Palant

The rebased version of this patch now makes both shouldAllow() and shouldAllowAsync() exported and uses ...

Nov. 12, 2015, 3:07 p.m. (2015-11-12 15:07:20 UTC) #4

tschuster

Nov. 18, 2015, 1:47 p.m. (2015-11-18 13:47:52 UTC) #5

LGTM

https://codereview.adblockplus.org/29329754/diff/29330095/lib/child/elemHide.js
File lib/child/elemHide.js (right):

https://codereview.adblockplus.org/29329754/diff/29330095/lib/child/elemHide....
lib/child/elemHide.js:134: let data = (allow ? allowXBL : hideXBL);
Oh yeah. That is pretty subtle. Especially with the previous name.

Expand All Messages | Collapse All Messages