Issue 3251 - Delegate processing of element hiding hits to shouldAllowAsync() so that hits show up

lib/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 62 matching lines @@
    * Inidicates whether the element hiding stylesheet is currently applied.
    * @type Boolean
    */
   applied: false,
 
   /**
    * Called on module startup.
    */
   init: function()
   {
-    Utils.addChildMessageListener("AdblockPlus:ElemHideHit", (data) => {
-      return ElemHide.shouldHide(data);
-    });
-
     Prefs.addListener(function(name)
     {
       if (name == "enabled")
         ElemHide.apply();
     });
     onShutdown.add(() => ElemHide.unapply());
 
     let styleFile = IO.resolveFilePath(Prefs.data_directory);
     styleFile.append("elemhide.css");
     styleURL = Services.io.newFileURI(styleFile).QueryInterface(Ci.nsIFileURL);
@@ skipping 85 matching lines @@
 
     let list = exceptions[filter.selector];
     for (let i = list.length - 1; i >= 0; i--)
       if (list[i].isActiveOnDomain(docDomain))
         return list[i];
 
     return null;
   },
 
   /**
-   * Processes an element hiding hit
-   * @param {String} message.key
-   *    key of the matching element hiding rule
-   * @param {Object[]} message.frames
-   *    information required to reconstruct frame
-   *    data for the hit
-   * @return {Boolean}
-   */
-  shouldHide: function(message)
-  {
-    let filter = ElemHide.getFilterByKey(message.key);
-    if (!filter || !message.frames.length)
-      return false;
-
-    let {Policy} = require("contentPolicy");
-    return !Policy.shouldAllow({
-      contentType: "ELEMHIDE",
-      location: filter,
-      frames: message.frames,
-      isPrivate: message.isPrivate
-    }).allow;
-  },
-
-  /**
    * Will be set to true if apply() is running (reentrance protection).
    * @type Boolean
    */
   _applying: false,
 
   /**
    * Will be set to true if an apply() call arrives while apply() is already
    * running (delayed execution).
    * @type Boolean
    */
@@ skipping 182 matching lines @@
       let filter = filterByKey[key];
       if (specificOnly && (!filter.domains || filter.domains[""]))
         continue;
 
       if (filter.isActiveOnDomain(domain) && !this.getException(filter, domain))
         result.push(filter.selector);
     }
     return result;
   }
 };