Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329776: Issue 3254 - Fix exception when navigating to about:addons and similar pages (Closed)

Created:
Nov. 5, 2015, 7:26 p.m. by Wladimir Palant
Modified:
Nov. 11, 2015, 7:49 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3254 - Fix exception when navigating to about:addons and similar pages

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M lib/notification.js View 1 chunk +15 lines, -1 line 2 comments Download

Messages

Total messages: 3
Wladimir Palant
Nov. 5, 2015, 7:26 p.m. (2015-11-05 19:26:05 UTC) #1
Thomas Greiner
LGTM https://codereview.adblockplus.org/29329776/diff/29329777/lib/notification.js File lib/notification.js (right): https://codereview.adblockplus.org/29329776/diff/29329777/lib/notification.js#newcode233 lib/notification.js:233: // Ignore, an exception is excepted for about: ...
Nov. 10, 2015, 5:54 p.m. (2015-11-10 17:54:19 UTC) #2
Wladimir Palant
Nov. 11, 2015, 7:49 a.m. (2015-11-11 07:49:28 UTC) #3
https://codereview.adblockplus.org/29329776/diff/29329777/lib/notification.js
File lib/notification.js (right):

https://codereview.adblockplus.org/29329776/diff/29329777/lib/notification.js...
lib/notification.js:233: // Ignore, an exception is excepted for about: and
similar schemes
On 2015/11/10 17:54:19, Thomas Greiner wrote:
> Detail: I suppose you meant to write "expected" here.

Yes, I fixed that before pushing.

Powered by Google App Engine
This is Rietveld