Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329815: Issue 3274 - Unbreak toolbar icon tooltip (Closed)

Created:
Nov. 6, 2015, 12:36 p.m. by Wladimir Palant
Modified:
Nov. 26, 2015, 1:46 p.m.
Visibility:
Public.

Description

Issue 3274 - Unbreak toolbar icon tooltip

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed JSDoc comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -43 lines) Patch
M lib/child/requestNotifier.js View 1 3 chunks +28 lines, -0 lines 0 comments Download
M lib/requestNotifier.js View 1 3 chunks +25 lines, -7 lines 0 comments Download
M lib/ui.js View 1 chunk +48 lines, -36 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Nov. 6, 2015, 12:36 p.m. (2015-11-06 12:36:07 UTC) #1
Thomas Greiner
LGTM, just a small change in the documentation https://codereview.adblockplus.org/29329815/diff/29329816/lib/child/requestNotifier.js File lib/child/requestNotifier.js (right): https://codereview.adblockplus.org/29329815/diff/29329816/lib/child/requestNotifier.js#newcode358 lib/child/requestNotifier.js:358: * ...
Nov. 24, 2015, 5:45 p.m. (2015-11-24 17:45:27 UTC) #2
tschuster
Nov. 25, 2015, 6:31 p.m. (2015-11-25 18:31:15 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld