Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(531)

Issue 29329839: Issue 3228 - Unbreak object tabs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by Wladimir Palant
Modified:
4 years, 6 months ago
Visibility:
Public.

Description

Issue 3228 - Unbreak object tabs

Patch Set 1 #

Total comments: 7

Patch Set 2 : Added comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -626 lines) Patch
M lib/child/contentPolicy.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/child/objectTabs.js View 6 chunks +15 lines, -119 lines 0 comments Download
M lib/child/requestNotifier.js View 1 1 chunk +46 lines, -0 lines 0 comments Download
M lib/contentPolicy.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M lib/main.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/objectTabs.js View 1 1 chunk +73 lines, -459 lines 0 comments Download
M lib/requestNotifier.js View 1 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
4 years, 7 months ago (2015-11-06 19:45:10 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29329839/diff/29329840/lib/child/objectTabs.js File lib/child/objectTabs.js (right): https://codereview.adblockplus.org/29329839/diff/29329840/lib/child/objectTabs.js#newcode316 lib/child/objectTabs.js:316: // TODO: Store this.currentElement for the filter assistant Making ...
4 years, 7 months ago (2015-11-06 19:52:43 UTC) #2
tschuster
LGTM https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js File lib/objectTabs.js (right): https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js#newcode26 lib/objectTabs.js:26: let classVisibleBottom = null; Please add a description ...
4 years, 6 months ago (2015-11-25 18:50:14 UTC) #3
Wladimir Palant
4 years, 6 months ago (2015-11-25 22:50:33 UTC) #4
Only lib/objectTabs.js changed, the rest of the changes is due to rebasing.

https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js
File lib/objectTabs.js (right):

https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js#n...
lib/objectTabs.js:26: let classVisibleBottom = null;
On 2015/11/25 18:50:13, tschuster wrote:
> Please add a description to those.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5