Issue 3228 - Unbreak object tabs

Issue 3228 - Unbreak object tabs

[Wladimir Palant, 2015-11-06 19:52:43]

https://codereview.adblockplus.org/29329839/diff/29329840/lib/child/objectTab...
File lib/child/objectTabs.js (right):

https://codereview.adblockplus.org/29329839/diff/29329840/lib/child/objectTab...
lib/child/objectTabs.js:316: // TODO: Store this.currentElement for the filter
assistant
Making filter assistant work with nodes correctly is
https://issues.adblockplus.org/ticket/3224.

https://codereview.adblockplus.org/29329839/diff/29329840/lib/child/requestNo...
File lib/child/requestNotifier.js (right):

https://codereview.adblockplus.org/29329839/diff/29329840/lib/child/requestNo...
lib/child/requestNotifier.js:377: RequestNotifier.getDataForNode =
function(node, noParent, type, location)
This function moved from lib/requestNotifier.js without any changes.

https://codereview.adblockplus.org/29329839/diff/29329840/lib/contentPolicy.js
File lib/contentPolicy.js (left):

https://codereview.adblockplus.org/29329839/diff/29329840/lib/contentPolicy.j...
lib/contentPolicy.js:32: let {objectMouseEventHander} = require("objectTabs");
This function is still being used by refilterNodes - but it is broken anyway and
has to be refactored in https://issues.adblockplus.org/ticket/3224.

https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js
File lib/objectTabs.js (right):

https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js#n...
lib/objectTabs.js:53: function init()
This is based on the _initCSS() function, but with some unnecessary complexity
removed - originally it was called when the first object tab was showing up, so
that the _showTab function had to be called again once the initialization was
done, also potential reentrance had to be considered.

[tschuster, 2015-11-25 18:50:14]

LGTM

https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js
File lib/objectTabs.js (right):

https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js#n...
lib/objectTabs.js:26: let classVisibleBottom = null;
Please add a description to those.

https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js#n...
lib/objectTabs.js:53: function init()
On 2015/11/06 19:52:43, Wladimir Palant wrote:
> This is based on the _initCSS() function, but with some unnecessary complexity
> removed - originally it was called when the first object tab was showing up,
so
> that the _showTab function had to be called again once the initialization was
> done, also potential reentrance had to be considered.

Thanks, that was helpful.

[Wladimir Palant, 2015-11-25 22:50:33]

Only lib/objectTabs.js changed, the rest of the changes is due to rebasing.

https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js
File lib/objectTabs.js (right):

https://codereview.adblockplus.org/29329839/diff/29329840/lib/objectTabs.js#n...
lib/objectTabs.js:26: let classVisibleBottom = null;
On 2015/11/25 18:50:13, tschuster wrote:
> Please add a description to those.

Done.