Issue 3228 - Unbreak object tabs

lib/objectTabs.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /**
  * @fileOverview Code responsible for showing and hiding object tabs.
  */
 
 let {Prefs} = require("prefs");
 let {Utils} = require("utils");
 
+/**
+ * Random element class, to be used for object tabs displayed on top of the
+ * plugin content.
+ * @type string
+ */
 let classVisibleTop = null;
+
+/**
+ * Random element class, to be used for object tabs displayed at the bottom of
+ * the plugin content.
+ * @type string
+ */
 let classVisibleBottom = null;

[tschuster, 2015/11/25 18:50:13]

Please add a description to those.

[Wladimir Palant, 2015/11/25 22:50:32]

Done.

+
+/**
+ * Random element class, to be used for object tabs that are hidden.
+ * @type string
+ */
 let classHidden = null;
 
 Utils.addChildMessageListener("AdblockPlus:GetObjectTabsStatus", function()
 {
   let {UI} = require("ui");
 
   return !!(Prefs.enabled && Prefs.frameobjects && UI.overlay && classHidden);
 });
 
 Utils.addChildMessageListener("AdblockPlus:GetObjectTabsTexts", function()
 {
   let {UI} = require("ui");
 
   return {
     label: UI.overlay.attributes.objtabtext,
     tooltip: UI.overlay.attributes.objtabtooltip,
     classVisibleTop, classVisibleBottom, classHidden
   };
 });
 
 Utils.addChildMessageListener("AdblockPlus:BlockItem", function(item)
 {
   let {UI} = require("ui");
   UI.blockItem(UI.currentWindow, null, item);
 });
 
 function init()

[Wladimir Palant, 2015/11/06 19:52:43]

This is based on the _initCSS() function, but with some unnecessary complexity
removed - originally it was called when the first object tab was showing up, so
that the _showTab function had to be called again once the initialization was
done, also potential reentrance had to be considered.

[tschuster, 2015/11/25 18:50:13]

Thanks, that was helpful.

 {
   function processCSSData(event)
   {
     if (onShutdown.done)
       return;
 
     let data = event.target.responseText;
 
     let rnd = [];
     let offset = "a".charCodeAt(0);
@@ skipping 23 matching lines @@
     request.overrideMimeType("text/plain");
     request.addEventListener("load", processCSSData, false);
     request.send(null);
   }
   catch (e)
   {
     Cu.reportError(e);
   }
 }
 init();