Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329895: Issue 3290 - Adblock Plus child modules don`t always start up (Closed)

Created:
Nov. 9, 2015, 3:37 p.m. by Wladimir Palant
Modified:
Dec. 2, 2015, 11:29 a.m.
Visibility:
Public.

Description

Issue 3290 - Adblock Plus child modules don`t always start up

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed unnecessary statement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M lib/child/bootstrap.js View 1 2 chunks +35 lines, -38 lines 0 comments Download
M lib/main.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
Wladimir Palant
Nov. 9, 2015, 3:38 p.m. (2015-11-09 15:38:00 UTC) #1
Wladimir Palant
Just a note: the bug is something completely stupid. I was broadcasting the AdblockPlus:Info message ...
Nov. 9, 2015, 3:41 p.m. (2015-11-09 15:41:08 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29329895/diff/29329896/lib/child/bootstrap.js File lib/child/bootstrap.js (right): https://codereview.adblockplus.org/29329895/diff/29329896/lib/child/bootstrap.js#newcode81 lib/child/bootstrap.js:81: removeMessageListener("AdblockPlus:Info", init); You removed `addMessageListener("AdblockPlus:Info", init);` so this should ...
Dec. 1, 2015, 3:40 p.m. (2015-12-01 15:40:27 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29329895/diff/29329896/lib/child/bootstrap.js File lib/child/bootstrap.js (right): https://codereview.adblockplus.org/29329895/diff/29329896/lib/child/bootstrap.js#newcode81 lib/child/bootstrap.js:81: removeMessageListener("AdblockPlus:Info", init); On 2015/12/01 15:40:27, Thomas Greiner wrote: > ...
Dec. 1, 2015, 7:12 p.m. (2015-12-01 19:12:22 UTC) #4
Thomas Greiner
Dec. 1, 2015, 7:16 p.m. (2015-12-01 19:16:22 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld