Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329899: Issue 3158 - Add CSS and HTML rules to coding style page (Closed)

Created:
Nov. 9, 2015, 5:31 p.m. by saroyanm
Modified:
Nov. 10, 2015, 2:31 p.m.
Reviewers:
Thomas Greiner
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3158 - Add CSS and HTML rules to coding style page

Patch Set 1 #

Total comments: 4

Patch Set 2 : Identifiers rename, consistency changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25 lines) Patch
M pages/coding-style.html View 1 2 chunks +37 lines, -25 lines 0 comments Download

Messages

Total messages: 4
saroyanm
@Thomas can please have a look whenever you will have time, it's nothing urgent, just ...
Nov. 9, 2015, 5:36 p.m. (2015-11-09 17:36:24 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29329899/diff/29329900/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29329899/diff/29329900/pages/coding-style.html#newcode35 pages/coding-style.html:35: <li>{{html-css1 Follow the <a href="https://google.github.io/styleguide/htmlcssguide.xml">Google HTML/CSS Style Guide</a>.}}</li> Please ...
Nov. 10, 2015, 9:51 a.m. (2015-11-10 09:51:01 UTC) #2
saroyanm
https://codereview.adblockplus.org/29329899/diff/29329900/pages/coding-style.html File pages/coding-style.html (right): https://codereview.adblockplus.org/29329899/diff/29329900/pages/coding-style.html#newcode35 pages/coding-style.html:35: <li>{{html-css1 Follow the <a href="https://google.github.io/styleguide/htmlcssguide.xml">Google HTML/CSS Style Guide</a>.}}</li> On ...
Nov. 10, 2015, 10:20 a.m. (2015-11-10 10:20:07 UTC) #3
Thomas Greiner
Nov. 10, 2015, 10:33 a.m. (2015-11-10 10:33:08 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld