Issue #3343 - Eliminate unescaping of URL

src/plugin/PluginClass.cpp

Index: src/plugin/PluginClass.cpp
===================================================================
--- a/src/plugin/PluginClass.cpp
+++ b/src/plugin/PluginClass.cpp
@@ -188,7 +188,6 @@
     if (SUCCEEDED(browser->get_LocationURL(&bstrURL)) && bstrURL)
     {
       url = std::wstring(bstrURL, SysStringLen(bstrURL));
-      UnescapeUrl(url);
     }
   }
   else
@@ -484,12 +483,11 @@
       return;
     }
     std::wstring url(urlVariant->bstrVal, SysStringLen(urlVariant->bstrVal));
-    UnescapeUrl(url);
 
     // If webbrowser2 is equal to top level browser (as set in SetSite), we are
     // navigating new page
     CPluginClient* client = CPluginClient::GetInstance();
-    if (url.find(L"javascript") == 0)
+    if (url.find(L"javascript") == std::wstring::npos)

[Oleksandr, 2015/11/25 02:24:29]

Nit: unrelated change.

[sergei, 2015/11/25 08:29:14]

It's even completely different condition.
`url.find(L"javascript") == 0` tests whether `url` begins with "javascript"
`url.find(L"javascript") == std::wstring::npos` tests whether url contains
"javascript".

[Eric, 2015/11/25 16:18:21]

Doh!

Reverted in new patch set.

     {
     }
     else if (GetBrowser().IsEqualObject(webBrowser))
@@ -545,7 +543,6 @@
       return;
     }
     std::wstring frameSrc = GetLocationUrl(*webBrowser2);
-    UnescapeUrl(frameSrc);
     bool isRootPageBrowser = GetBrowser().IsEqualObject(webBrowser2);
     m_tab->OnDocumentComplete(webBrowser2, frameSrc, isRootPageBrowser);
   }