Issue #3343 - Eliminate unescaping of URL

Issue #3343 - Eliminate unescaping of URL

Remove UnescapeUrl() and all calls to it.

[Eric, 2015-11-23 14:18:51]

If we're going to stop unescaping URL's entirely, this is how you do it.

I haven't created an issue for it, though. Since the unescaping has been in the
code ever since I first looked at it, I'd suggest that this change needs some
testing before committing to it.

[Oleksandr, 2015-11-23 14:35:14]

I think this should definitely not be a "Noissue" commit. FYI:
https://issues.adblockplus.org/ticket/3343

[Eric, 2015-11-23 14:47:28]

On 2015/11/23 14:35:14, Oleksandr wrote:
> I think this should definitely not be a "Noissue" commit.

I agree with that. We just didn't have an issue in place already.

> https://issues.adblockplus.org/ticket/3343

This issue is just for the two calls before ShouldBlock(). The present review
removes all the calls, everywhere.

[Oleksandr, 2015-11-25 02:24:29]

I don't think we can commit a changeset like this without an appropriate issue.
I have modified https://issues.adblockplus.org/ticket/3343 to be more generic.

I have tested various scenarios to see if IE ever does any unescaping before we
do. Luckily it doesn't look like it does, so hopefully this won't break
anything. So looks good with a nit addressed and commit message changed.

https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginCl...
File src/plugin/PluginClass.cpp (right):

https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginCl...
src/plugin/PluginClass.cpp:490: if (url.find(L"javascript") ==
std::wstring::npos)
Nit: unrelated change.

[sergei, 2015-11-25 08:29:14]

https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginCl...
File src/plugin/PluginClass.cpp (right):

https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginCl...
src/plugin/PluginClass.cpp:490: if (url.find(L"javascript") ==
std::wstring::npos)
On 2015/11/25 02:24:29, Oleksandr wrote:
> Nit: unrelated change.

It's even completely different condition.
`url.find(L"javascript") == 0` tests whether `url` begins with "javascript"
`url.find(L"javascript") == std::wstring::npos` tests whether url contains
"javascript".

[Eric, 2015-11-25 16:18:21]

Changed the commit message to issue #3343.

https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginCl...
File src/plugin/PluginClass.cpp (right):

https://codereview.adblockplus.org/29330709/diff/29330710/src/plugin/PluginCl...
src/plugin/PluginClass.cpp:490: if (url.find(L"javascript") ==
std::wstring::npos)
Doh!

Reverted in new patch set.

[Oleksandr, 2015-11-25 17:31:46]

LGTM

[sergei, 2015-11-26 11:12:19]

LGTM