package.json - Issue 29331068: Noissue - Populate package.json to avoid npm warnings (abp2blocklist)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: package.json

Issue 29331068: Noissue - Populate package.json to avoid npm warnings (abp2blocklist) (Closed)

Left Patch Set: Created Nov. 26, 2015, 5:04 p.m.

Right Patch Set: Add absolute minimum to avoid warnings on npm install Created Nov. 27, 2015, 9:01 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "name": "abp2blocklist",

3 "description": "A script to convert Adblock Plus filter lists to WebKit block lists",

4 "license" : "GPL-3.0",	2 "license" : "GPL-3.0",
	Sebastian Noack 2015/11/27 09:06:06 I just tested it. And it seems the repository file I just tested it. And it seems the repository filed is actually the only one causing a warning if missing. kzar 2015/11/27 09:13:22 I also get a warning if the license field is missi Show quoted text On 2015/11/27 09:06:06, Sebastian Noack wrote: > I just tested it. And it seems the repository filed is actually the only one > causing a warning if missing. I also get a warning if the license field is missing: npm WARN abp2blocklist No license field. Sebastian Noack 2015/11/27 09:22:55 OK, maybe you have a different version of npm. LGT Show quoted text On 2015/11/27 09:13:22, kzar wrote: > On 2015/11/27 09:06:06, Sebastian Noack wrote: > > I just tested it. And it seems the repository filed is actually the only one > > causing a warning if missing. > > I also get a warning if the license field is missing: > > npm WARN abp2blocklist No license field. OK, maybe you have a different version of npm. LGTM
5 "repository": {	3 "repository": { },

6 "type": "mercurial",

7 "url": "https://hg.adblockplus.org/abp2blocklist"

8 },

9 "dependencies": {	4 "dependencies": {

10 "tldjs": "*"	5 "tldjs": "*"

11 }	6 }

12 }	7 }

LEFT	RIGHT