Issue 29331068: Noissue - Populate package.json to avoid npm warnings (abp2blocklist)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29331068: Noissue - Populate package.json to avoid npm warnings (abp2blocklist) (Closed)

Created:
Nov. 26, 2015, 5:04 p.m. by kzar

Modified:
Nov. 27, 2015, 9:43 a.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Noissue - Populate package.json to avoid npm warnings

Patch Set 2 : Add absolute minimum to avoid warnings on npm install #

Total comments: 3

Created: Nov. 27, 2015, 9:01 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	package.json	View	1	1 chunk	+2 lines, -0 lines	3 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Sebastian Noack

All these data are redundant, and since we really only use package.json to install dependencies ...

Nov. 27, 2015, 6 a.m. (2015-11-27 06:00:34 UTC) #2

kzar

Patch Set 2 : Add absolute minimum to avoid warnings on npm install

Nov. 27, 2015, 9:01 a.m. (2015-11-27 09:01:55 UTC) #3

Sebastian Noack

https://codereview.adblockplus.org/29331068/diff/29331099/package.json File package.json (right): https://codereview.adblockplus.org/29331068/diff/29331099/package.json#newcode2 package.json:2: "license" : "GPL-3.0", I just tested it. And it ...

Nov. 27, 2015, 9:06 a.m. (2015-11-27 09:06:06 UTC) #4

kzar

Nov. 27, 2015, 9:13 a.m. (2015-11-27 09:13:23 UTC) #5

Sebastian Noack

Nov. 27, 2015, 9:22 a.m. (2015-11-27 09:22:55 UTC) #6

https://codereview.adblockplus.org/29331068/diff/29331099/package.json
File package.json (right):

https://codereview.adblockplus.org/29331068/diff/29331099/package.json#newcode2
package.json:2: "license" : "GPL-3.0",
On 2015/11/27 09:13:22, kzar wrote:
> On 2015/11/27 09:06:06, Sebastian Noack wrote:
> > I just tested it. And it seems the repository filed is actually the only one
> > causing a warning if missing.
> 
> I also get a warning if the license field is missing:
> 
>   npm WARN abp2blocklist No license field.

OK, maybe you have a different version of npm. LGTM

Expand All Messages | Collapse All Messages