includes/press/releases.tmpl - Issue 29332433: Issue 3366 - Add tab for press releases to eyeo.com/press

Delta Between Two Patch Sets: includes/press/releases.tmpl

Issue 29332433: Issue 3366 - Add tab for press releases to eyeo.com/press (Closed)

Left Patch Set: Addressed Thomas Comments Created Dec. 11, 2015, 7:13 p.m.

Right Patch Set: Addressed Thomas comments Created Dec. 14, 2015, 4:27 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {% set releases_en = [	1 {% set releases = [

2 ("October 30, 2015", "First Free Ad Blocker on the Apple App Store Arrives; Th e Adblock Autumn: Adblock Plus for iOS 2-nd from ABP this Month", "2015-09-30-A BP_for_iOSApp-WEB.pdf"),	2 ("September 30, 2015", "en", "First Free Ad Blocker on the Apple App Store Arr ives; The Adblock Autumn: Adblock Plus for iOS 2-nd from ABP this Month", "2015 -09-30-ABP_for_iOSApp-WEB.pdf"),
Thomas Greiner 2015/12/14 12:56:58 Actually, I meant that the editor (in this case Be Actually, I meant that the editor (in this case Ben) should only need to enter "2015-09-30" and that a Python filter sorts and formats those dates accordingly. Thereby we avoid spelling mistakes, ordering issues and inconsistent date formats. That would also make it easier for us to make it translatable whenever we decide to add those capabilities to eyeo.com. Sidenote: The document title says "2015-09-30" which is "September 30, 2015". Again, that's one of the benefits of leaving this to Python. saroyanm 2015/12/14 16:30:06 I've created a ticket to tackle that issue later b Show quoted text On 2015/12/14 12:56:58, Thomas Greiner wrote: > Actually, I meant that the editor (in this case Ben) should only need to enter > "2015-09-30" and that a Python filter sorts and formats those dates accordingly. > > Thereby we avoid spelling mistakes, ordering issues and inconsistent date > formats. That would also make it easier for us to make it translatable whenever > we decide to add those capabilities to http://eyeo.com. > > Sidenote: The document title says "2015-09-30" which is "September 30, 2015". > Again, that's one of the benefits of leaving this to Python. I've created a ticket to tackle that issue later because of tight schedule: https://issues.adblockplus.org/ticket/3410
3 ("October 29, 2015", "Adblock Plus To Invite An Independent Board to Manage 'A cceptable Ads' Program", "2015-09-29-AA_independent_board-WEB.pdf"),	3 ("October 29, 2015", "en", "Adblock Plus To Invite An Independent Board to Man age 'Acceptable Ads' Program", "2015-09-29-AA_independent_board-WEB.pdf"),
	Thomas Greiner 2015/12/15 12:59:57 Detail: The formatted dates here and in the line b Detail: The formatted dates here and in the line below are also wrong.
4 ("October 15, 2015", "Sweet 4‐Peat for Users: Adblock Plus Victorious In Cour t Against Axel Springer", "2015-09-15-Cologne-lawsuitWIN-WEB.pdf"),	4 ("October 15, 2015", "en", "Sweet 4‐Peat for Users: Adblock Plus Victorious I n Court Against Axel Springer", "2015-09-15-Cologne-lawsuitWIN-WEB.pdf"),

5 ("September 08, 2015", "Adblock Plus beats Apple to the punch; Ships Adblock B rowser ahead of iOS 9", "2015-09-08-AdblockBrowserforiOSLaunch(POST)-WEB.pdf"),	5 ("September 08, 2015", "en", "Adblock Plus beats Apple to the punch; Ships Adb lock Browser ahead of iOS 9", "2015-09-08-AdblockBrowserforiOSLaunch(POST)-WEB.p df"),

6 ("September 08, 2015", "Adblock Plus Escapes Exile; Returns to Google Play Sto re", "2015-09-08-Adblock BrowserforAndroid(POST)-WEB.pdf"),	6 ("September 08, 2015", "en", "Adblock Plus Escapes Exile; Returns to Google Pl ay Store", "2015-09-08-Adblock BrowserforAndroid(POST)-WEB.pdf"),

7 ("July 08, 2015", "University Tests Adblock Plus on Enterprise Network; Finds 40% Traffic Reduction", "2015-07-08-ABP-SFUStudyWEB.pdf"),	7 ("July 08, 2015", "en", "University Tests Adblock Plus on Enterprise Network; Finds 40% Traffic Reduction", "2015-07-08-ABP-SFUStudyWEB.pdf"),

8 ("May 19, 2015", "Adblock Plus Builds First Mobile Browser From the Ground Up; Leaves Ad Industry With Nowhere to Hide", "2015-05-19-AdblockBrowserAndroidBeta -WEB.pdf"),	8 ("May 19, 2015", "en", "Adblock Plus Builds First Mobile Browser From the Grou nd Up; Leaves Ad Industry With Nowhere to Hide", "2015-05-19-AdblockBrowserAndro idBeta-WEB.pdf"),

9 ("January 27, 2015", "Adblock Plus for Internet Explorer Officially Out of Bet a", "2015-01-27-Maxthon-US-WEB.pdf"),	9 ("January 27, 2015", "en", "Adblock Plus for Internet Explorer Officially Out of Beta", "2015-01-27-Maxthon-US-WEB.pdf"),

10 ("April 04, 2014", "Research Study Finds ‘Loud’ Website Ads Do Not Work", "201 4-04-29-Eyetracking-WEB.pdf"),	10 ("April 04, 2014", "en", "Research Study Finds 'Loud' Website Ads Do Not Work" , "2014-04-29-Eyetracking-WEB.pdf"),

11 ("October 10, 2013", "Adblock Plus Available for Safari; Mac Owners Rejoice", "2013-10-10-29-ABP-on-Safari-WEB.pdf"),	11 ("October 10, 2013", "en", "Adblock Plus Available for Safari; Mac Owners Rejo ice", "2013-10-10-29-ABP-on-Safari-WEB.pdf"),

	12 ("September 30, 2015", "de", "Unabhängiges Gremium entscheidet bald über 'Acce ptable Ads' bei Adblock Plus", "2015-09-30-AAIndependentBoard_DE.pdf"),

	13 ("September 29, 2015", "de", "4:0 für das Selbstbestimmungsrecht des Nutzers! Adblock Plus gewinnt Klage gegen Axel Springer vor Kölner Landgericht", "2015-09 -29-CologneLawsuit-DE.pdf"),

	14 ("September 10, 2015", "de", "Adblock Browser aus dem Exil entlassen - endlich zurück im Google Play Store!", "2015-09-10-Adblock_Browser_für_Android-DE.pdf") ,

	15 ("September 08, 2015", "de", "Adblock Plus schneller dran als Apple - Adblock Browser kommt noch vor iOS 9!", "2015-09-08-Adblock_Browser_für_iOS_Launch-DE.pd f"),

	16 ("September 08, 2015", "de", "Adblock Browser aus dem Exil entlassen - endlich zurück im Google Play Store!", "2015-09-08-Adblock_Browser_für_Android-DE.pdf") ,

	17 ("July 03, 2015", "de", "Universität testet Adblock Plus auf Unternehmensnetzw erk und reduziert den Datenverbrauch damit um 40%", "2015-07-03-SFU_Press_Releas e-DE.pdf"),

	18 ("May 19, 2015", "de", "Werbeblocker 'Adblock Plus' launcht eigenen Android-Br owser", "2015-05-19-AdblockBrowserpressrelease-DE.pdf"),

	19 ("February 02, 2015", "de", "Maxthon und AdblockPlus schließen strategische Pa rtnerschaft zum Launch des ersten Browsers, der Werbung standardmäßig blockiert" , "2015-02-09-MaxthonPressRelease-DE.pdf"),

	20 ("April 04, 2014", "de", "Erstaunliche neue Studie zur Werbewirkung: Dezente A nzeigen funktionieren besser", "2014-04-29-Eyetrackingtranslatedplusblog.pdf"),

	21 ("June 06, 2013", "de", "Neue Studie zu Werbung im Netz: Kinder von OnlineAnz eigen oftmals überfordert", "2013-06-20_KinderOnline-Werbung-DE.pdf"),

12 ] %}	22 ] %}

13	23

14 {% set releases_de = [	24 {% set languages = [

15 ("September 30, 2015", "Unabhängiges Gremium entscheidet bald über 'Acceptable Ads' bei Adblock Plus", "2015-09-30-AAIndependentBoard_DE.pdf"),	25 ("en", "English"),

16 ("September 29, 2015", "4:0 für das Selbstbestimmungsrecht des Nutzers! Adbloc k Plus gewinnt Klage gegen Axel Springer vor Kölner Landgericht", "2015-09-29-Co logneLawsuit-DE.pdf"),	26 ("de", "German"),

17 ("September 10, 2015", "Adblock Browser aus dem Exil entlassen - endlich zurüc k im Google Play Store!", "2015-09-10-Adblock_Browser_für_Android-DE.pdf"),

18 ("September 08, 2015", "Adblock Plus schneller dran als Apple - Adblock Browse r kommt noch vor iOS 9!", "2015-09-08-Adblock_Browser_für_iOS_Launch-DE.pdf"),

19 ("September 08, 2015", "Adblock Browser aus dem Exil entlassen - endlich zurüc k im Google Play Store!", "2015-09-08-Adblock_Browser_für_Android-DE.pdf"),

20 ("July 03, 2015", "Universität testet Adblock Plus auf Unternehmensnetzwerk un d reduziert den Datenverbrauch damit um 40%", "2015-07-03-SFU_Press_Release-DE.p df"),

21 ("May 19, 2015", "Werbeblocker 'Adblock Plus' launcht eigenen Android-Browser" , "2015-05-19-AdblockBrowserpressrelease-DE.pdf"),

22 ("February 02, 2015", "Maxthon und AdblockPlus schließen strategische Partners chaft zum Launch des ersten Browsers, der Werbung standardmäßig blockiert", "201 5-02-09-MaxthonPressRelease-DE.pdf"),

23 ("April 04, 2014", "Erstaunliche neue Studie zur Werbewirkung: Dezente Anzeige n funktionieren besser", "2014-04-29-Eyetrackingtranslatedplusblog.pdf"),

24 ("June 06, 2013", "Neue Studie zu Werbung im Netz: Kinder von OnlineAnzeigen oftmals überfordert", "2013-06-20_KinderOnline-Werbung-DE.pdf"),

25 ] %}	27 ] %}

26	28

27 <p>	29 {% for code, language in languages %}

28 <a href="#english">English</a>	30 <p>

29 </p>	31 <a href="#releases-{{code}}">{{language}}</a>

30 <p>	32 </p>

31 <a href="#german">German</a>	33 {% endfor %}

32 </p>

33	34

34 <h3 id="english">English</h3>	35 {% for code, language in languages %}
Thomas Greiner 2015/12/14 12:56:58 What about creating a macro for that instead of re What about creating a macro for that instead of repeating the same block per language? e.g. {% macro list_releases(list_lang, list_name) %} <h3 id="{{list_lang}}">{{list_name}}</h3> <ul> {% for lang, date, title, file in releases %} {% if lang == list_lang %} <li> <div>{{date}}</div> <a href="/press/releases/{{list_lang}}/{{file}}">{{title}}</a> </li> {% endif %} {% endfor %} </ul> {% endmacro %} {{list_releases("en", "English")}} {{list_releases("de", "German")}} saroyanm 2015/12/14 16:30:06 I think in that case also create dynamically the r Show quoted text On 2015/12/14 12:56:58, Thomas Greiner wrote: > What about creating a macro for that instead of repeating the same block per > language? > > e.g. > {% macro list_releases(list_lang, list_name) %} > <h3 id="{{list_lang}}">{{list_name}}</h3> > <ul> > {% for lang, date, title, file in releases %} > {% if lang == list_lang %} > <li> > <div>{{date}}</div> > <a href="/press/releases/{{list_lang}}/{{file}}">{{title}}</a> > </li> > {% endif %} > {% endfor %} > </ul> > {% endmacro %} > > {{list_releases("en", "English")}} > > {{list_releases("de", "German")}} I think in that case also create dynamically the reference part. Done.
35 <ul>	36 <h3 id="releases-{{code}}">{{language}}</h3>

36 {% for date, title, file in releases_en %}	37 <ul>

37 <li>	38 {% for date, lang, title, file in releases %}

38 <div>{{date}}</div><a href="/press/releases/en/{{file}}">{{title}}</a>	39 {% if lang == code %}
Thomas Greiner 2015/12/14 12:56:58 Detail: Anything against putting each tag here in Detail: Anything against putting each tag here in its own line? That'd make it look a bit cleaner. saroyanm 2015/12/14 16:30:07 Done. Show quoted text On 2015/12/14 12:56:58, Thomas Greiner wrote: > Detail: Anything against putting each tag here in its own line? That'd make it > look a bit cleaner. Done.
39 </li>	40 <li>

40 {% endfor %}	41 <div>{{date}}</div>

41 </ul>	42 <a href="/press/releases/{{code}}/{{file}}">{{title}}</a>

42	43 </li>

43 <h3 id="german">German</h3>	44 {% endif %}

44 <ul>	45 {% endfor %}

45 {% for date, title, file in releases_de %}	46 </ul>

46 <li>

47 <div>{{date}}</div><a href="/press/releases/de/{{file}}">{{title}}</a>

48 </li>

49 {% endfor %}	47 {% endfor %}

50 </ul>

LEFT	RIGHT