Issue 3366 - Add tab for press releases to eyeo.com/press

I've also updated the pdf file names, removed white-spaces, renamed the dates. Also removed styles and files that are no more used.

[saroyanm, 2015-12-07 17:26:35]

@Thomas can you please have a look when you have time.

[Thomas Greiner, 2015-12-11 16:48:01]

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
File includes/press/releases.md (right):

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
includes/press/releases.md:7: * <span>October 10, 2013</span> [Adblock Plus
Available for Safari; Mac Owners
Rejoice](/press/releases/en/2013-10-10-29-ABP-on-Safari-WEB.pdf)
Dates are not sorted in descending order as specified in the ticket description.

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
includes/press/releases.md:7: * <span>October 10, 2013</span> [Adblock Plus
Available for Safari; Mac Owners
Rejoice](/press/releases/en/2013-10-10-29-ABP-on-Safari-WEB.pdf)
I'm not confident that a Markdown file is the proper solution here since we
don't want non-developers to write HTML and also want to ensure correctly
formatted dates and sorted entries.

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
includes/press/releases.md:8: * <span>April 04, 2014</span> [Research Study
Finds ‘Loud’ Website Ads Do Not
Work](/press/releases/en/2014-04-29-Eyetracking-WEB.pdf)
Detail: Replace `‘` with `'`

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
includes/press/releases.md:10: * <span>May 19, 2015</span> [Adblock Plus Builds
First Mobile Browser From the Ground Up;
Are the newline characters intentional?

https://codereview.adblockplus.org/29332433/diff/29332434/static/css/styles.css
File static/css/styles.css (right):

https://codereview.adblockplus.org/29332433/diff/29332434/static/css/styles.c...
static/css/styles.css:444: #releases li span
Detail: `<div>` seems more appropriate for this purpose since it's more of a
block than an inline element.

[saroyanm, 2015-12-11 19:16:37]

Having some problems with Uploading PDF files, please note that changes are only
on includes/press/releases.tmpl and static/css/styles.css

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
File includes/press/releases.md (right):

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
includes/press/releases.md:7: * <span>October 10, 2013</span> [Adblock Plus
Available for Safari; Mac Owners
Rejoice](/press/releases/en/2013-10-10-29-ABP-on-Safari-WEB.pdf)
On 2015/12/11 16:48:00, Thomas Greiner wrote:
> Dates are not sorted in descending order as specified in the ticket
description.

Done.

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
includes/press/releases.md:7: * <span>October 10, 2013</span> [Adblock Plus
Available for Safari; Mac Owners
Rejoice](/press/releases/en/2013-10-10-29-ABP-on-Safari-WEB.pdf)
On 2015/12/11 16:48:00, Thomas Greiner wrote:
> I'm not confident that a Markdown file is the proper solution here since we
> don't want non-developers to write HTML and also want to ensure correctly
> formatted dates and sorted entries.

Done.

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
includes/press/releases.md:8: * <span>April 04, 2014</span> [Research Study
Finds ‘Loud’ Website Ads Do Not
Work](/press/releases/en/2014-04-29-Eyetracking-WEB.pdf)
On 2015/12/11 16:48:00, Thomas Greiner wrote:
> Detail: Replace `‘` with `'`

Done.

https://codereview.adblockplus.org/29332433/diff/29332434/includes/press/rele...
includes/press/releases.md:10: * <span>May 19, 2015</span> [Adblock Plus Builds
First Mobile Browser From the Ground Up;
On 2015/12/11 16:48:00, Thomas Greiner wrote:
> Are the newline characters intentional?

No, done.

https://codereview.adblockplus.org/29332433/diff/29332434/static/css/styles.css
File static/css/styles.css (right):

https://codereview.adblockplus.org/29332433/diff/29332434/static/css/styles.c...
static/css/styles.css:444: #releases li span
On 2015/12/11 16:48:00, Thomas Greiner wrote:
> Detail: `<div>` seems more appropriate for this purpose since it's more of a
> block than an inline element.

Agree, done.

[Thomas Greiner, 2015-12-14 12:56:59]

https://codereview.adblockplus.org/29332433/diff/29332571/includes/press/rele...
File includes/press/releases.tmpl (right):

https://codereview.adblockplus.org/29332433/diff/29332571/includes/press/rele...
includes/press/releases.tmpl:2: ("October 30, 2015", "First Free Ad Blocker on
the Apple App Store Arrives; The Adblock Autumn:  Adblock Plus for iOS 2-nd from
ABP this Month", "2015-09-30-ABP_for_iOSApp-WEB.pdf"),
Actually, I meant that the editor (in this case Ben) should only need to enter
"2015-09-30" and that a Python filter sorts and formats those dates accordingly.

Thereby we avoid spelling mistakes, ordering issues and inconsistent date
formats. That would also make it easier for us to make it translatable whenever
we decide to add those capabilities to eyeo.com.

Sidenote: The document title says "2015-09-30" which is "September 30, 2015".
Again, that's one of the benefits of leaving this to Python.

https://codereview.adblockplus.org/29332433/diff/29332571/includes/press/rele...
includes/press/releases.tmpl:34: <h3 id="english">English</h3>
What about creating a macro for that instead of repeating the same block per
language?

e.g.
{% macro list_releases(list_lang, list_name) %}
<h3 id="{{list_lang}}">{{list_name}}</h3>
<ul>
{% for lang, date, title, file in releases %}
{% if lang == list_lang %}
  <li>
    <div>{{date}}</div>
    <a href="/press/releases/{{list_lang}}/{{file}}">{{title}}</a>
  </li>
{% endif %}
{% endfor %}
</ul>
{% endmacro %}

{{list_releases("en", "English")}}

{{list_releases("de", "German")}}

https://codereview.adblockplus.org/29332433/diff/29332571/includes/press/rele...
includes/press/releases.tmpl:38: <div>{{date}}</div><a
href="/press/releases/en/{{file}}">{{title}}</a>
Detail: Anything against putting each tag here in its own line? That'd make it
look a bit cleaner.

[saroyanm, 2015-12-14 16:30:08]

New patch uploaded.

https://codereview.adblockplus.org/29332433/diff/29332571/includes/press/rele...
File includes/press/releases.tmpl (right):

https://codereview.adblockplus.org/29332433/diff/29332571/includes/press/rele...
includes/press/releases.tmpl:2: ("October 30, 2015", "First Free Ad Blocker on
the Apple App Store Arrives; The Adblock Autumn:  Adblock Plus for iOS 2-nd from
ABP this Month", "2015-09-30-ABP_for_iOSApp-WEB.pdf"),
On 2015/12/14 12:56:58, Thomas Greiner wrote:
> Actually, I meant that the editor (in this case Ben) should only need to enter
> "2015-09-30" and that a Python filter sorts and formats those dates
accordingly.
> 
> Thereby we avoid spelling mistakes, ordering issues and inconsistent date
> formats. That would also make it easier for us to make it translatable
whenever
> we decide to add those capabilities to http://eyeo.com.
> 
> Sidenote: The document title says "2015-09-30" which is "September 30, 2015".
> Again, that's one of the benefits of leaving this to Python.

I've created a ticket to tackle that issue later because of tight schedule:
https://issues.adblockplus.org/ticket/3410

https://codereview.adblockplus.org/29332433/diff/29332571/includes/press/rele...
includes/press/releases.tmpl:34: <h3 id="english">English</h3>
On 2015/12/14 12:56:58, Thomas Greiner wrote:
> What about creating a macro for that instead of repeating the same block per
> language?
> 
> e.g.
> {% macro list_releases(list_lang, list_name) %}
> <h3 id="{{list_lang}}">{{list_name}}</h3>
> <ul>
> {% for lang, date, title, file in releases %}
> {% if lang == list_lang %}
>   <li>
>     <div>{{date}}</div>
>     <a href="/press/releases/{{list_lang}}/{{file}}">{{title}}</a>
>   </li>
> {% endif %}
> {% endfor %}
> </ul>
> {% endmacro %}
> 
> {{list_releases("en", "English")}}
> 
> {{list_releases("de", "German")}}

I think in that case also create dynamically the reference part. Done.

https://codereview.adblockplus.org/29332433/diff/29332571/includes/press/rele...
includes/press/releases.tmpl:38: <div>{{date}}</div><a
href="/press/releases/en/{{file}}">{{title}}</a>
On 2015/12/14 12:56:58, Thomas Greiner wrote:
> Detail: Anything against putting each tag here in its own line? That'd make it
> look a bit cleaner.

Done.

[Thomas Greiner, 2015-12-15 12:59:58]

One more comment but LGTM after that's been fixed

https://codereview.adblockplus.org/29332433/diff/29332654/includes/press/rele...
File includes/press/releases.tmpl (right):

https://codereview.adblockplus.org/29332433/diff/29332654/includes/press/rele...
includes/press/releases.tmpl:3: ("October 29, 2015", "en", "Adblock Plus To
Invite An Independent Board to Manage 'Acceptable Ads' Program",
"2015-09-29-AA_independent_board-WEB.pdf"),
Detail: The formatted dates here and in the line below are also wrong.