Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332484: Noissue - Add conversion function from 'BSTR' to 'std::wstring' (Closed)

Created:
Dec. 9, 2015, 1:02 p.m. by Eric
Modified:
Dec. 14, 2015, 11:31 a.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Noissue - Add conversion function from 'BSTR' to 'std::wstring' ---- Extracted from the following review: https://codereview.adblockplus.org/29331055/ The function defined here is the only dependency of another review which depended upon the one above: https://codereview.adblockplus.org/29332057/ Extracted to avoid dependency delays.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M adblockplus.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/shared/Utils.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/shared/Utils.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Eric
In order to avoid delays about whether some code is too beautiful to live, I've ...
Dec. 9, 2015, 1:13 p.m. (2015-12-09 13:13:49 UTC) #1
sergei
LGTM
Dec. 9, 2015, 1:20 p.m. (2015-12-09 13:20:09 UTC) #2
Oleksandr
Dec. 14, 2015, 12:56 a.m. (2015-12-14 00:56:23 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld