Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332503: No Issue - Add support for using "sup" tag in translation strings (Closed)

Created:
Dec. 9, 2015, 7:15 p.m. by saroyanm
Modified:
Dec. 11, 2015, 2:33 p.m.
CC:
kzar
Visibility:
Public.

Description

No Issue - Add support for using "sup" tag in translation strings

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cms/converters.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5
saroyanm
Sebastian can you please have a look when you have time, if you can do ...
Dec. 9, 2015, 7:25 p.m. (2015-12-09 19:25:58 UTC) #1
Sebastian Noack
LGTM
Dec. 9, 2015, 7:37 p.m. (2015-12-09 19:37:28 UTC) #2
Wladimir Palant
NOT LGTM. https://codereview.adblockplus.org/29332503/diff/29332504/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29332503/diff/29332504/cms/converters.py#newcode112 cms/converters.py:112: whitelist = {"a", "em", "sup", "strong", "code", ...
Dec. 9, 2015, 8:33 p.m. (2015-12-09 20:33:45 UTC) #3
saroyanm
On 2015/12/09 20:33:45, Wladimir Palant wrote: > NOT LGTM. > > https://codereview.adblockplus.org/29332503/diff/29332504/cms/converters.py > File cms/converters.py ...
Dec. 9, 2015, 9:35 p.m. (2015-12-09 21:35:33 UTC) #4
Wladimir Palant
Dec. 9, 2015, 9:43 p.m. (2015-12-09 21:43:07 UTC) #5
Looking at http://www.w3.org/TR/html5/common-idioms.html#footnotes, it seems
that <sup> is indeed the proposed markup for footnote references. Well then,
LGTM.

Powered by Google App Engine
This is Rietveld