Issue 3257 - Create uninstallation page in adblockplus.org (use GET http request)

Aligned with designers and Job regarding changes here, they are fine with that, like placement of characters count, wording.

[saroyanm, 2015-12-14 13:56:08]

@Sebastian can you please have a look ?

[Sebastian Noack, 2015-12-14 14:16:34]

https://codereview.adblockplus.org/29332615/diff/29332625/pages/uninstalled.tmpl
File pages/uninstalled.tmpl (left):

https://codereview.adblockplus.org/29332615/diff/29332625/pages/uninstalled.t...
pages/uninstalled.tmpl:31: input.setAttribute("name", paramSplit[0]);
The parameter key can theoretically also include unsafe characters. So you
should use decodeURICompnent here as well.

https://codereview.adblockplus.org/29332615/diff/29332625/pages/uninstalled.tmpl
File pages/uninstalled.tmpl (right):

https://codereview.adblockplus.org/29332615/diff/29332625/pages/uninstalled.t...
pages/uninstalled.tmpl:53: reasonOther.removeAttribute("class")
How about using |.classList.toggle("hidden")|?

[saroyanm, 2015-12-14 14:48:12]

New patch uploaded.

https://codereview.adblockplus.org/29332615/diff/29332625/pages/uninstalled.tmpl
File pages/uninstalled.tmpl (left):

https://codereview.adblockplus.org/29332615/diff/29332625/pages/uninstalled.t...
pages/uninstalled.tmpl:31: input.setAttribute("name", paramSplit[0]);
On 2015/12/14 14:16:34, Sebastian Noack wrote:
> The parameter key can theoretically also include unsafe characters. So you
> should use decodeURICompnent here as well.

Done.

https://codereview.adblockplus.org/29332615/diff/29332625/pages/uninstalled.tmpl
File pages/uninstalled.tmpl (right):

https://codereview.adblockplus.org/29332615/diff/29332625/pages/uninstalled.t...
pages/uninstalled.tmpl:53: reasonOther.removeAttribute("class")
On 2015/12/14 14:16:34, Sebastian Noack wrote:
> How about using |.classList.toggle("hidden")|?

Done.

[Sebastian Noack, 2015-12-14 14:51:40]

https://codereview.adblockplus.org/29332615/diff/29332628/pages/uninstalled.tmpl
File pages/uninstalled.tmpl (right):

https://codereview.adblockplus.org/29332615/diff/29332628/pages/uninstalled.t...
pages/uninstalled.tmpl:52: reasonOther.classList.toggle("hidden")
Nit: Missing semicolon

[saroyanm, 2015-12-14 14:53:19]

https://codereview.adblockplus.org/29332615/diff/29332628/pages/uninstalled.tmpl
File pages/uninstalled.tmpl (right):

https://codereview.adblockplus.org/29332615/diff/29332628/pages/uninstalled.t...
pages/uninstalled.tmpl:52: reasonOther.classList.toggle("hidden")
On 2015/12/14 14:51:40, Sebastian Noack wrote:
> Nit: Missing semicolon

Ahh, sorry for that, Done.

[Sebastian Noack, 2015-12-14 14:59:49]

LGTM