Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332677: Noissue - Trace life cycle of 'CPluginClass' (Closed)

Created:
Dec. 15, 2015, 4:25 p.m. by Eric
Modified:
Jan. 5, 2016, 2:28 p.m.
Reviewers:
sergei, Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Noissue - Trace life cycle of 'CPluginClass' Add trace messages to `CPluginClass` at four points: constructor, destructor, 'SetSite(non-null)' and 'SetSite(0)'. ----- Depends on the following review: Noissue - Add tracing function 'ToHexLiteral()' https://codereview.adblockplus.org/29332020/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M src/plugin/PluginClass.cpp View 6 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Eric
This is how I investigated the behavior of IE calling 'CPluginClass::SetSite()'. (Well, it's rewritten to ...
Dec. 15, 2015, 4:37 p.m. (2015-12-15 16:37:27 UTC) #1
Eric
P.S. The current implementation of the logging functions can drop messages at the beginning and ...
Dec. 15, 2015, 5 p.m. (2015-12-15 17:00:36 UTC) #2
Oleksandr
I would prefer to use wstringstream in all lambda functions, but I won't insist. LGTM.
Jan. 5, 2016, 1:45 a.m. (2016-01-05 01:45:48 UTC) #3
sergei
Jan. 5, 2016, 11:47 a.m. (2016-01-05 11:47:34 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld