Issue 29332683: Noissue - Removed unused info.addonID and info.addonRoot for Chrome and Safari

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29332683: Noissue - Removed unused info.addonID and info.addonRoot for Chrome and Safari (Closed)

Created:
Dec. 15, 2015, 4:27 p.m. by Sebastian Noack

Modified:
Dec. 15, 2015, 6:07 p.m.

Reviewers:
kzar

CC:
Wladimir Palant

Visibility:
Public.

Description

Noissue - Removed unused info.addonID for Chrome and Safari

Patch Set 1 #

Patch Set 2 : Also remove unused addonRoot #

Created: Dec. 15, 2015, 4:52 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	chromeInfo.js.tmpl	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
	M	safariInfo.js.tmpl	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kzar

Well I did grep for the stuff you've removed quickly and it appears you're correct ...

Dec. 15, 2015, 5:38 p.m. (2015-12-15 17:38:34 UTC) #4

Sebastian Noack

Dec. 15, 2015, 5:50 p.m. (2015-12-15 17:50:08 UTC) #5

On 2015/12/15 17:38:34, kzar wrote:
> Well I did grep for the stuff you've removed quickly and it appears you're
> correct that it was all redundant. It's your change though so it's up to you
to
> make sure that it doesn't break anything.

Well, besides a grep I did a quick smoke test. Nothing seems to break. Moreover,
these properties seems to be very Firefox/Gecko specific.

Expand All Messages | Collapse All Messages