Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(380)

Issue 29332780: Issue 3418 - Replace expression closures in prefs.js (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by Wladimir Palant
Modified:
4 years, 1 month ago
Visibility:
Public.

Description

Issue 3418 - Replace expression closures in prefs.js

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -42 lines) Patch
M lib/prefs.js View 3 chunks +45 lines, -42 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
4 years, 1 month ago (2015-12-16 10:06:43 UTC) #1
Thomas Greiner
LGTM
4 years, 1 month ago (2015-12-16 10:37:25 UTC) #2
Sebastian Noack
4 years, 1 month ago (2015-12-16 10:40:34 UTC) #3
LGTM. But note that this is kinda a duplicate of #1434. However, your patch
seems to replace more non-standard syntax in prefs.js.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5