Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332780: Issue 3418 - Replace expression closures in prefs.js (Closed)

Created:
Dec. 16, 2015, 10:06 a.m. by Wladimir Palant
Modified:
Dec. 16, 2015, 10:51 a.m.
Visibility:
Public.

Description

Issue 3418 - Replace expression closures in prefs.js

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -42 lines) Patch
M lib/prefs.js View 3 chunks +45 lines, -42 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Dec. 16, 2015, 10:06 a.m. (2015-12-16 10:06:43 UTC) #1
Thomas Greiner
LGTM
Dec. 16, 2015, 10:37 a.m. (2015-12-16 10:37:25 UTC) #2
Sebastian Noack
Dec. 16, 2015, 10:40 a.m. (2015-12-16 10:40:34 UTC) #3
LGTM. But note that this is kinda a duplicate of #1434. However, your patch
seems to replace more non-standard syntax in prefs.js.

Powered by Google App Engine
This is Rietveld