Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332801: Issue 3424 - Update buildtools dependency for URL Fixer to revisoin b02d0532e33c (Closed)

Created:
Dec. 16, 2015, 1:17 p.m. by Wladimir Palant
Modified:
Dec. 17, 2015, 10:59 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Please have a look at the tests for hooks.js I added here. That is very much an ad hoc solution but better than nothing. Erik is working on a new test framework which will hopefully give us a better way to write this kind of tests in future.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -1 line) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
A tests.html View 1 chunk +173 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Dec. 16, 2015, 1:17 p.m. (2015-12-16 13:17:27 UTC) #1
Thomas Greiner
LGTM Note the typo in the review title.
Dec. 16, 2015, 4:19 p.m. (2015-12-16 16:19:20 UTC) #2
Wladimir Palant
Dec. 17, 2015, 10:59 a.m. (2015-12-17 10:59:23 UTC) #3
On 2015/12/16 16:19:20, Thomas Greiner wrote:
> Note the typo in the review title.

Thank you, fixed that typo in issue and commit title.

Powered by Google App Engine
This is Rietveld