Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332835: Noissue - Clean up in 'WbPassthruSink' (Closed)

Dec. 16, 2015, 5:29 p.m. by Eric
Feb. 8, 2016, 4:32 p.m.
sergei, Oleksandr
Felix Dahlke


Noissue - Clean up in 'WbPassthruSink' Add documentation for data used to inform the fix for ticket #3237. Rename 'WbPassthruSink::Get{...}' functions to 'Infer{...}' to better reflect their actual function. Move them from private static functions into an anonymous namespace. Rename "mime type" names to "media type list" names to reflect what the data actually is. Change the visibility of a number of public member variables to private.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -67 lines) Patch
M src/plugin/PluginWbPassThrough.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 2 chunks +71 lines, -61 lines 0 comments Download


Total messages: 4
I decided I cared enough to prepare the addendum to the recent defect fix. Sorry ...
Dec. 16, 2015, 5:33 p.m. (2015-12-16 17:33:46 UTC) #1
LGTM, if committed with that description as a commit message.
Feb. 5, 2016, 6:50 a.m. (2016-02-05 06:50:13 UTC) #2
Feb. 8, 2016, 10:05 a.m. (2016-02-08 10:05:08 UTC) #3
Feb. 8, 2016, 4:31 p.m. (2016-02-08 16:31:35 UTC) #4
On 2016/02/05 06:50:13, Oleksandr wrote:
> if committed with that description as a commit message

I always cut-n-paste the change set description from my local repository into
the description of the review. Occasionally I need addenda about dependencies at
the end.

It would be better if there were a separate database field for this (with script
support to make it automatic), but there's not.

Powered by Google App Engine
This is Rietveld