Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1252)

Issue 29332893: Issue 3431 - Element Hiding Helper shutdown fails (shutdown is not a function) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by Wladimir Palant
Modified:
3 years, 7 months ago
Reviewers:
saroyanm
Visibility:
Public.

Description

This is partly a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1202902, but module unloading also fails because the chrome package is already unregistered at that point.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixed style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/content/actor.jsm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/frameScript.js View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 7 months ago (2015-12-21 12:16:29 UTC) #1
saroyanm
https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/actor.jsm File chrome/content/actor.jsm (right): https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/actor.jsm#newcode30 chrome/content/actor.jsm:30: var shutdown = (function() What is the reason of ...
3 years, 7 months ago (2015-12-21 13:45:18 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/actor.jsm File chrome/content/actor.jsm (right): https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/actor.jsm#newcode30 chrome/content/actor.jsm:30: var shutdown = (function() On 2015/12/21 13:45:18, saroyanm wrote: ...
3 years, 7 months ago (2015-12-21 19:02:00 UTC) #3
saroyanm
3 years, 7 months ago (2015-12-23 10:55:34 UTC) #4
LGTM

https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/acto...
File chrome/content/actor.jsm (right):

https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/acto...
chrome/content/actor.jsm:30: var shutdown = (function()
On 2015/12/21 19:01:59, Wladimir Palant wrote:
> On 2015/12/21 13:45:18, saroyanm wrote:
> > What is the reason of using "var" here ?
> 
> As I said, the problem here is
> https://bugzilla.mozilla.org/show_bug.cgi?id=1202902 - let will no longer
> declare a global variable any more. And it has to be global in order to be
> exported.

Got it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5