Issue 29332893: Issue 3431 - Element Hiding Helper shutdown fails (shutdown is not a function)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29332893: Issue 3431 - Element Hiding Helper shutdown fails (shutdown is not a function) (Closed)

Created:
Dec. 21, 2015, 12:16 p.m. by Wladimir Palant

Modified:
Dec. 23, 2015, 12:52 p.m.

Reviewers:
saroyanm

Visibility:
Public.

Description

This is partly a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1202902, but module unloading also fails because the chrome package is already unregistered at that point.

Patch Set 2 : Fixed style #

Created: Dec. 21, 2015, 7:01 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/content/actor.jsm	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/content/frameScript.js	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

saroyanm

https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/actor.jsm File chrome/content/actor.jsm (right): https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/actor.jsm#newcode30 chrome/content/actor.jsm:30: var shutdown = (function() What is the reason of ...

Dec. 21, 2015, 1:45 p.m. (2015-12-21 13:45:18 UTC) #2

Wladimir Palant

Dec. 21, 2015, 7:02 p.m. (2015-12-21 19:02:00 UTC) #3

saroyanm

Dec. 23, 2015, 10:55 a.m. (2015-12-23 10:55:34 UTC) #4

LGTM

https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/acto...
File chrome/content/actor.jsm (right):

https://codereview.adblockplus.org/29332893/diff/29332894/chrome/content/acto...
chrome/content/actor.jsm:30: var shutdown = (function()
On 2015/12/21 19:01:59, Wladimir Palant wrote:
> On 2015/12/21 13:45:18, saroyanm wrote:
> > What is the reason of using "var" here ?
> 
> As I said, the problem here is
> https://bugzilla.mozilla.org/show_bug.cgi?id=1202902 - let will no longer
> declare a global variable any more. And it has to be global in order to be
> exported.

Got it.

Expand All Messages | Collapse All Messages