Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/frameScript.js

Issue 29332893: Issue 3431 - Element Hiding Helper shutdown fails (shutdown is not a function) (Closed)
Patch Set: Created Dec. 21, 2015, 12:16 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/content/actor.jsm ('K') | « chrome/content/actor.jsm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/frameScript.js
===================================================================
--- a/chrome/content/frameScript.js
+++ b/chrome/content/frameScript.js
@@ -14,17 +14,22 @@
addMessageListener("ElemHideHelper:Shutdown", onShutdown);
addMessageListener("ElemHideHelper:GetNodeInfo", onGetNodeInfo);
addMessageListener("ElemHideHelper:Preview", onTogglePreview);
function onShutdown()
{
shutdown();
- Cu.unload(module);
+ try {
+ Cu.unload(module);
+ } catch (e) {
saroyanm 2015/12/21 13:45:18 Nit: please move catch to it's own line to make it
Wladimir Palant 2015/12/21 19:01:59 Done.
+ Cu.reportError(e);
+ }
+
removeMessageListener("ElemHideHelper:Shutdown", onShutdown);
removeMessageListener("ElemHideHelper:GetNodeInfo", onGetNodeInfo);
removeMessageListener("ElemHideHelper:Preview", onTogglePreview);
}
function onGetNodeInfo(message)
{
let nodeInfo = getNodeInfo(message.objects.element);
« chrome/content/actor.jsm ('K') | « chrome/content/actor.jsm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld