Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/child/bootstrap.js

Issue 29332950: Issue 3449 - Use sendRpcMessage instead of sendSyncMessage (Closed)
Patch Set: Created Dec. 22, 2015, 10:08 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/child/bootstrap.js
===================================================================
--- a/lib/child/bootstrap.js
+++ b/lib/child/bootstrap.js
@@ -45,17 +45,17 @@
};
let callbackPrefix = Services.appinfo.processID + " ";
let maxCallbackID = 0;
let callbacks = new Map();
function sendSyncMessageSingleResponse(messageName, data)
saroyanm 2015/12/28 10:01:44 nit: I think you can also change the function name
Wladimir Palant 2015/12/28 13:11:03 I don't think the name should be changed - that's
{
- return sendSyncMessage(messageName, {data})[0];
+ return sendRpcMessage(messageName, {data})[0];
}
function sendAsyncMessageWithResponse(messageName, data, callback)
{
data = {data};
if (callback)
{
let callbackID = callbackPrefix + (++maxCallbackID);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld