Issue #1484 - Use the currently distributed version of PassthroughAPP unaltered

Issue #1484 - Use the currently distributed version of PassthroughAPP unaltered

Replace the PassthroughAPP code with the currently-released version.
    https://github.com/salsita/passthruapp
This change set does not change anything about the build. It continues to use
the same directory for PassthroughAPP as before.

Add definition for minimum IE version of 7.0. New version of PassthroughAPP
uses interfaces introduced with that version, including 'OnStartEx()'. The new
version of PassthroughAPP calls this entry point instead of the older one.
Change 'WBPassthruSink::OnStart()' to 'OnStartEx()'.

[Eric, 2015-12-22 17:23:04]

New PassthroughAPP code is identical to what's on github. The review tool diff
is not showing much of the indentation change as just indentation.

Compiles, but is throwing a debug assertion. I haven't looked into it yet. My
initial guess the new version is finding some pre-existing defect in our code.

Posted as a review in case anybody wants to look at it before I get back to it.

[Eric, 2015-12-23 15:23:39]

Patch set 1 is the external version of PassthroughAPP and a definition needed to
get it to compile.

Patch set 2 is a modification to our own code to get it to work. The new
PassthroughAPP calls 'OnStartEx()' now, so the only modification was to change
the name and signature of 'OnStart()'. The change in the signature did not
affect the plugin code.

[Oleksandr, 2016-02-05 07:02:12]

LGTM

[sergei, 2016-02-26 19:53:57]

https://codereview.adblockplus.org/29332980/diff/29333053/src/plugin/PluginSt...
File src/plugin/PluginStdAfx.h (right):

https://codereview.adblockplus.org/29332980/diff/29333053/src/plugin/PluginSt...
src/plugin/PluginStdAfx.h:41: #define _WIN32_IE _WIN32_IE_IE70
We support IE starting from IE 8, wouldn't it be better to use `_WIN32_IE_IE80`
here?

https://codereview.adblockplus.org/29332980/diff/29333053/src/plugin/PluginWb...
File src/plugin/PluginWbPassThrough.h (right):

https://codereview.adblockplus.org/29332980/diff/29333053/src/plugin/PluginWb...
src/plugin/PluginWbPassThrough.h:68: HRESULT OnStartEx(IUri* pUri,
IInternetProtocolSink* pOIProtSink,
There is still Start method which calls OnStart, is it really never called now?

[Eric, 2016-05-19 16:10:20]

https://codereview.adblockplus.org/29332980/diff/29333053/src/plugin/PluginSt...
File src/plugin/PluginStdAfx.h (right):

https://codereview.adblockplus.org/29332980/diff/29333053/src/plugin/PluginSt...
src/plugin/PluginStdAfx.h:41: #define _WIN32_IE _WIN32_IE_IE70
On 2016/02/26 19:53:56, sergei wrote:
> We support IE starting from IE 8, wouldn't it be better to use
`_WIN32_IE_IE80`
> here?

The way these definitions work, they turn on new features introduced in each
browser, possibly changing behaviors. Using an older definition is a more
conservative choice, with less possibility of regression.

If there is some IE 8+ feature we need, we can always bump it up. The new
version of PassthroughAPP requires minimum IE 7, so that's what I used in order
to avoid potential complications.

https://codereview.adblockplus.org/29332980/diff/29333053/src/plugin/PluginWb...
File src/plugin/PluginWbPassThrough.h (right):

https://codereview.adblockplus.org/29332980/diff/29333053/src/plugin/PluginWb...
src/plugin/PluginWbPassThrough.h:68: HRESULT OnStartEx(IUri* pUri,
IInternetProtocolSink* pOIProtSink,
On 2016/02/26 19:53:56, sergei wrote:
> There is still Start method which calls OnStart, is it really never called
now?

It doesn't appear to be called at all. I verified this with the debugger.

Frankly, I'm not sure why 'OnStart' is still in the PassthroughAPP code base.
Recall, though, that people other than the original author Tandetnik are now
maintaining the code. I suspect that it's an oversight.