Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333141: Issue 3458 - When blocking pop-ups, consider the case where window.opener becomes null due to redir… (Closed)

Created:
Jan. 4, 2016, 4:42 p.m. by Wladimir Palant
Modified:
Jan. 5, 2016, 9:36 a.m.
Reviewers:
Erik
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 3458 - When blocking pop-ups, consider the case where window.opener becomes null due to redirect.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M lib/child/contentPolicy.js View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Jan. 4, 2016, 4:42 p.m. (2016-01-04 16:42:58 UTC) #1
Erik
LGTM
Jan. 4, 2016, 9:46 p.m. (2016-01-04 21:46:58 UTC) #2
Erik
Jan. 4, 2016, 11:27 p.m. (2016-01-04 23:27:29 UTC) #3

          

Powered by Google App Engine
This is Rietveld