Issue 29333150: Issue 3461 - Fixed: Issue Reporter assumes that RequestEntry.filter is a Filter instance, not a str…

Issue 29333150: Issue 3461 - Fixed: Issue Reporter assumes that RequestEntry.filter is a Filter instance, not a str… (Closed)

Created:
Jan. 4, 2016, 5:46 p.m. by Wladimir Palant

Modified:
Jan. 6, 2016, 4:16 p.m.

Reviewers:
Sebastian Noack, Erik

CC:
Thomas Greiner

Visibility:
Public.

Description

Issue 3461 - Fixed: Issue Reporter assumes that RequestEntry.filter is a Filter instance, not a string.

Patch Set 2 : Addressed comment #

Total comments: 1

Created: Jan. 5, 2016, 9:49 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/content/ui/sendReport.js	View	1	1 chunk	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Sebastian Noack

https://codereview.adblockplus.org/29333150/diff/29333151/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (left): https://codereview.adblockplus.org/29333150/diff/29333151/chrome/content/ui/sendReport.js#oldcode827 chrome/content/ui/sendReport.js:827: for (let i = 0; i < requests.length; i++) ...

Jan. 4, 2016, 6:14 p.m. (2016-01-04 18:14:52 UTC) #2

Wladimir Palant

Jan. 4, 2016, 7:23 p.m. (2016-01-04 19:23:44 UTC) #3

Sebastian Noack

Jan. 5, 2016, 9:20 a.m. (2016-01-05 09:20:53 UTC) #4

Wladimir Palant

https://codereview.adblockplus.org/29333150/diff/29333151/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): https://codereview.adblockplus.org/29333150/diff/29333151/chrome/content/ui/sendReport.js#newcode833 chrome/content/ui/sendReport.js:833: if (!filter.subscriptions.filter(s => !s.disabled).length) On 2016/01/05 09:20:52, Sebastian Noack ...

Jan. 5, 2016, 9:50 a.m. (2016-01-05 09:50:08 UTC) #5

LGTM

Expand All Messages | Collapse All Messages