Issue 3407 - Remove Policy.isWindowWhitelisted() method and its callers

chrome/content/ui/sendReport.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 900 matching lines @@
     {
       return subscriptionsDataSource.subscriptionFilter(s);
     }
     else
       return false;
   },
 
   collectData: function(wnd, windowURI, callback)
   {
     this.contentWnd = wnd;
-    this.whitelistFilter = Policy.isWindowWhitelisted(wnd);
+    this.whitelistFilter = Policy.isWhitelisted(windowURI.spec);

[Thomas Greiner, 2016/01/05 15:12:24]

In line 591 we implement a fallback for when `windowURI` is `null` so it
probably makes sense to implement it here as well:

windowURI ? windowURI.spec : wnd.location.href

[Wladimir Palant, 2016/01/05 15:22:48]

No, we will rather have to fix line 591 as part of issue 3375 - the wnd
parameter is going away, we shouldn't access content windows directly. windowURI
parameter cannot actually be null, see UI.openReportDialog().

[Thomas Greiner, 2016/01/05 16:19:55]

Fine with me then.

 
     if (!this.whitelistFilter && this.isEnabled)
     {
       // Find disabled filters in active subscriptions matching any of the requests
       let disabledMatcher = new CombinedMatcher();
       for (let subscription of FilterStorage.subscriptions)
       {
         if (subscription.disabled)
           continue;
 
@@ skipping 658 matching lines @@
 
 function censorURL(url)
 {
   return url.replace(/([?;&\/#][^?;&\/#]+?=)[^?;&\/#]+/g, "$1*");
 }
 
 function encodeHTML(str)
 {
   return str.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;");
 }