Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333159: Issue 3407 - Remove Policy.isWindowWhitelisted() method and its callers (Closed)

Created:
Jan. 4, 2016, 7:32 p.m. by Wladimir Palant
Modified:
Jan. 6, 2016, 12:26 p.m.
Reviewers:
Thomas Greiner
CC:
Erik
Visibility:
Public.

Description

Issue 3407 - Remove Policy.isWindowWhitelisted() method and its callers

Patch Set 1 #

Patch Set 2 : Removed unrelated change #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M chrome/content/ui/sendReport.js View 1 chunk +1 line, -1 line 3 comments Download
M chrome/content/ui/sidebar.js View 7 chunks +20 lines, -5 lines 0 comments Download
M lib/contentPolicy.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Jan. 4, 2016, 7:32 p.m. (2016-01-04 19:32:33 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29333159/diff/29333165/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): https://codereview.adblockplus.org/29333159/diff/29333165/chrome/content/ui/sendReport.js#newcode921 chrome/content/ui/sendReport.js:921: this.whitelistFilter = Policy.isWhitelisted(windowURI.spec); In line 591 we implement a ...
Jan. 5, 2016, 3:12 p.m. (2016-01-05 15:12:24 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29333159/diff/29333165/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): https://codereview.adblockplus.org/29333159/diff/29333165/chrome/content/ui/sendReport.js#newcode921 chrome/content/ui/sendReport.js:921: this.whitelistFilter = Policy.isWhitelisted(windowURI.spec); On 2016/01/05 15:12:24, Thomas Greiner wrote: ...
Jan. 5, 2016, 3:22 p.m. (2016-01-05 15:22:48 UTC) #3
Thomas Greiner
Jan. 5, 2016, 4:19 p.m. (2016-01-05 16:19:56 UTC) #4
LGTM

https://codereview.adblockplus.org/29333159/diff/29333165/chrome/content/ui/s...
File chrome/content/ui/sendReport.js (right):

https://codereview.adblockplus.org/29333159/diff/29333165/chrome/content/ui/s...
chrome/content/ui/sendReport.js:921: this.whitelistFilter =
Policy.isWhitelisted(windowURI.spec);
On 2016/01/05 15:22:48, Wladimir Palant wrote:
> windowURI parameter cannot actually be null, see UI.openReportDialog().

Fine with me then.

Powered by Google App Engine
This is Rietveld