Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333248: Issue 3306 - Create uplinks for pushing log files (Closed)

Created:
Jan. 6, 2016, 12:09 p.m. by mathias
Modified:
Jan. 20, 2016, 11:22 a.m.
Reviewers:
Fred
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3306 - Create uplinks for pushing log files

Patch Set 1 #

Total comments: 4

Patch Set 2 : Issue 3306 - Address feedback from code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -5 lines) Patch
A modules/adblockplus/files/log/import.py View 1 chunk +50 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/log.pp View 1 chunk +26 lines, -0 lines 0 comments Download
M modules/adblockplus/manifests/log/master.pp View 1 2 chunks +56 lines, -5 lines 0 comments Download
A modules/adblockplus/manifests/log/uplink.pp View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mathias
Jan. 6, 2016, 12:09 p.m. (2016-01-06 12:09:36 UTC) #1
Fred
https://codereview.adblockplus.org/29333248/diff/29333249/modules/adblockplus/manifests/log.pp File modules/adblockplus/manifests/log.pp (right): https://codereview.adblockplus.org/29333248/diff/29333249/modules/adblockplus/manifests/log.pp#newcode12 modules/adblockplus/manifests/log.pp:12: $group = 'log' This group named 'log' seems not ...
Jan. 7, 2016, 3:19 p.m. (2016-01-07 15:19:16 UTC) #2
mathias
https://codereview.adblockplus.org/29333248/diff/29333249/modules/adblockplus/manifests/log.pp File modules/adblockplus/manifests/log.pp (right): https://codereview.adblockplus.org/29333248/diff/29333249/modules/adblockplus/manifests/log.pp#newcode12 modules/adblockplus/manifests/log.pp:12: $group = 'log' On 2016/01/07 15:19:16, Fred wrote: > ...
Jan. 14, 2016, 3:03 p.m. (2016-01-14 15:03:53 UTC) #3
mathias
Jan. 14, 2016, 3:05 p.m. (2016-01-14 15:05:40 UTC) #4
Fred
Jan. 18, 2016, 5:18 p.m. (2016-01-18 17:18:35 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld