Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333297: Issue 3375 - Issue reporter: move screenshot creation into the content process (Closed)

Created:
Jan. 7, 2016, 4:59 p.m. by Wladimir Palant
Modified:
Jan. 8, 2016, 4:29 p.m.
Reviewers:
Thomas Greiner
CC:
Erik
Visibility:
Public.

Description

Issue 3375 - Issue reporter: move screenshot creation into the content process

Patch Set 1 #

Total comments: 1

Patch Set 2 : Made sure screenshotDataCollector is always initialized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -73 lines) Patch
M chrome/content/ui/sendReport.js View 1 1 chunk +28 lines, -73 lines 0 comments Download
A lib/child/dataCollector.js View 1 chunk +112 lines, -0 lines 0 comments Download
M lib/child/main.js View 1 chunk +1 line, -0 lines 0 comments Download
A lib/dataCollector.js View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Jan. 7, 2016, 4:59 p.m. (2016-01-07 16:59:59 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29333297/diff/29333298/lib/child/dataCollector.js File lib/child/dataCollector.js (right): https://codereview.adblockplus.org/29333297/diff/29333298/lib/child/dataCollector.js#newcode68 lib/child/dataCollector.js:68: function* createScreenshot(window, screenshotWidth) This function is mostly what we ...
Jan. 7, 2016, 5:02 p.m. (2016-01-07 17:02:59 UTC) #2
Thomas Greiner
Jan. 8, 2016, 4:07 p.m. (2016-01-08 16:07:04 UTC) #3
LGTM

I also verified that the newly introduced flow using Task.jsm works as expected.

Powered by Google App Engine
This is Rietveld