Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333347: Issue 3495 - Error Running Tests - SyntaxError: missing ] after element list (Closed)

Created:
Jan. 9, 2016, 12:40 a.m. by Erik
Modified:
Jan. 19, 2016, 12:35 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3495 - Error Running Tests - SyntaxError: missing ] after element list Some change in Firefox Nightly broke syntax like this: `[x for x of []]`

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/content/index.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
Thomas Greiner
Jan. 13, 2016, 12:42 p.m. (2016-01-13 12:42:45 UTC) #1
LGTM

Sorry for the late response but I wasn't aware of this review.

Note that before you commit this code please make sure that the following has
been done:
- Ticket was set to "ready" by module owner
- Ticket priority was set by module owner
- Ticket status was set to "reviewing"
- Ticket contains review URLs

Ideally, this should be done before starting the code review.

Powered by Google App Engine
This is Rietveld