Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333389: Issue 3502 - Don`t use expression closures in Issue Reporter (Closed)

Created:
Jan. 12, 2016, 3:52 p.m. by Wladimir Palant
Modified:
Jan. 12, 2016, 5:16 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3502 - Don`t use expression closures in Issue Reporter

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Added missing semicolons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/content/ui/sendReport.js View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Jan. 12, 2016, 3:52 p.m. (2016-01-12 15:52:25 UTC) #1
Thomas Greiner
LGTM, just a minor comment https://codereview.adblockplus.org/29333389/diff/29333398/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): https://codereview.adblockplus.org/29333389/diff/29333398/chrome/content/ui/sendReport.js#newcode386 chrome/content/ui/sendReport.js:386: return this._enabled Detail: Missing ...
Jan. 12, 2016, 4:02 p.m. (2016-01-12 16:02:02 UTC) #2
Wladimir Palant
Jan. 12, 2016, 5:14 p.m. (2016-01-12 17:14:42 UTC) #3
https://codereview.adblockplus.org/29333389/diff/29333398/chrome/content/ui/s...
File chrome/content/ui/sendReport.js (right):

https://codereview.adblockplus.org/29333389/diff/29333398/chrome/content/ui/s...
chrome/content/ui/sendReport.js:386: return this._enabled
On 2016/01/12 16:02:02, Thomas Greiner wrote:
> Detail: Missing semicolon (same below)

Done.

Powered by Google App Engine
This is Rietveld