Issue 3505 - Fixed: Issue reporter calls String.replace() with deprecated flags parameter

chrome/content/ui/sendReport.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 599 matching lines @@
       let [pathID, placeholder] = pathList[i];
       try
       {
         let file = FileUtils.getDir(pathID, [], false);
         censored[file.path.replace(/[\\\/]+$/, '')] = placeholder;
         let uri = Utils.ioService.newFileURI(file);
         censored[uri.spec.replace(/[\\\/]+$/, '')] = placeholder;
       } catch(e) {}
     }
 
+    function str2regexp(str, flags)
+    {
+      return new RegExp(str.replace(/(\W)/g, "\\$1"), flags);

[Thomas Greiner, 2016/01/12 17:53:39]

You can avoid the creation of the capturing group by using "\\$&" instead.

[Wladimir Palant, 2016/01/12 17:59:12]

Done.

+    }
+
     let errors = reportElement("errors");
     for (let i = 0; i < messages.length; i++)
     {
       let message = messages[i];
 
       let text = message.errorMessage;
       for (let path in censored)
-        text = text.replace(path, censored[path], "gi");
+        text = text.replace(str2regexp(path, "gi"), censored[path]);
       if (text.length > 256)
         text = text.substr(0, 256) + "...";
 
       let file = message.sourceName;
       for (let path in censored)
-        file = file.replace(path, censored[path], "gi");
+        file = file.replace(str2regexp(path, "gi"), censored[path]);
       if (file.length > 256)
         file = file.substr(0, 256) + "...";
 
       let sourceLine = message.sourceLine;
       if (sourceLine.length > 256)
         sourceLine = sourceLine.substr(0, 256) + "...";
 
       appendElement(errors, "error", {
         type: message.flags & Ci.nsIScriptError.warningFlag ? "warning" : "error",
         text: text,
@@ skipping 905 matching lines @@
 
 function censorURL(url)
 {
   return url.replace(/([?;&\/#][^?;&\/#]+?=)[^?;&\/#]+/g, "$1*");
 }
 
 function encodeHTML(str)
 {
   return str.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;");
 }