Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333409: Issue 3505 - Fixed: Issue reporter calls String.replace() with deprecated flags parameter (Closed)

Created:
Jan. 12, 2016, 5:07 p.m. by Wladimir Palant
Modified:
Jan. 12, 2016, 6:06 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3505 - Fixed: Issue reporter calls String.replace() with deprecated flags parameter

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed capturing group #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/content/ui/sendReport.js View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Jan. 12, 2016, 5:07 p.m. (2016-01-12 17:07:50 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29333409/diff/29333410/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): https://codereview.adblockplus.org/29333409/diff/29333410/chrome/content/ui/sendReport.js#newcode622 chrome/content/ui/sendReport.js:622: return new RegExp(str.replace(/(\W)/g, "\\$1"), flags); You can avoid the ...
Jan. 12, 2016, 5:53 p.m. (2016-01-12 17:53:39 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29333409/diff/29333410/chrome/content/ui/sendReport.js File chrome/content/ui/sendReport.js (right): https://codereview.adblockplus.org/29333409/diff/29333410/chrome/content/ui/sendReport.js#newcode622 chrome/content/ui/sendReport.js:622: return new RegExp(str.replace(/(\W)/g, "\\$1"), flags); On 2016/01/12 17:53:39, Thomas ...
Jan. 12, 2016, 5:59 p.m. (2016-01-12 17:59:12 UTC) #3
Thomas Greiner
Jan. 12, 2016, 6 p.m. (2016-01-12 18:00:48 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld